RESOLVED FIXED 201040
Make MediaStreamTrackPrivate RefCounted 
https://bugs.webkit.org/show_bug.cgi?id=201040
Summary Make MediaStreamTrackPrivate RefCounted
youenn fablet
Reported 2019-08-22 08:58:43 PDT
There is no need to ref MediaStreamTrackPrivate on a background thread
Attachments
Patch (1.62 KB, patch)
2019-08-22 09:00 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Improved change log (1.93 KB, patch)
2019-08-26 05:58 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-08-22 09:00:47 PDT
Created attachment 377013 [details] Patch
Darin Adler
Comment 2 2019-08-23 10:42:37 PDT
Comment on attachment 377013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377013&action=review I’m going to say review+, but I am just taking your word for it that this is correct. > Source/WebCore/ChangeLog:3 > + Make MediaStreamTrackPrivate RefCounted Really need a "why" comment in the change log. I think it’s "MediaStreamTrackPrivate does not need to be ThreadSafeRefCounted because all use of these objects including ref/deref is on the main thread."
youenn fablet
Comment 3 2019-08-26 05:58:37 PDT
Created attachment 377240 [details] Improved change log
WebKit Commit Bot
Comment 4 2019-08-27 00:38:47 PDT
Comment on attachment 377240 [details] Improved change log Clearing flags on attachment: 377240 Committed r249134: <https://trac.webkit.org/changeset/249134>
WebKit Commit Bot
Comment 5 2019-08-27 00:38:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-27 00:39:20 PDT
<rdar://problem/54738510>
Note You need to log in before you can comment on or make changes to this bug.