Bug 201040 - Make MediaStreamTrackPrivate RefCounted
Summary: Make MediaStreamTrackPrivate RefCounted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-22 08:58 PDT by youenn fablet
Modified: 2019-08-27 00:39 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2019-08-22 09:00 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Improved change log (1.93 KB, patch)
2019-08-26 05:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-08-22 08:58:43 PDT 
There is no need to ref MediaStreamTrackPrivate on a background thread
Comment 1 youenn fablet 2019-08-22 09:00:47 PDT 
Created attachment 377013 [details]
Patch
Comment 2 Darin Adler 2019-08-23 10:42:37 PDT 
Comment on attachment 377013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377013&action=review

I’m going to say review+, but I am just taking your word for it that this is correct.

> Source/WebCore/ChangeLog:3
> +        Make MediaStreamTrackPrivate RefCounted

Really need a "why" comment in the change log.

I think it’s "MediaStreamTrackPrivate does not need to be ThreadSafeRefCounted because all use of these objects including ref/deref is on the main thread."
Comment 3 youenn fablet 2019-08-26 05:58:37 PDT 
Created attachment 377240 [details]
Improved change log
Comment 4 WebKit Commit Bot 2019-08-27 00:38:47 PDT 
Comment on attachment 377240 [details]
Improved change log

Clearing flags on attachment: 377240

Committed r249134: <https://trac.webkit.org/changeset/249134>
Comment 5 WebKit Commit Bot 2019-08-27 00:38:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-27 00:39:20 PDT 
<rdar://problem/54738510>