RESOLVED FIXED 201036
Remove MaximalFlushInsertionPhase 
https://bugs.webkit.org/show_bug.cgi?id=201036
Summary Remove MaximalFlushInsertionPhase
Tadeu Zagallo
Reported 2019-08-22 08:02:41 PDT
...
Attachments
Patch (32.90 KB, patch)
2019-08-22 17:02 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (33.24 KB, patch)
2019-08-23 15:25 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-08-22 17:02:55 PDT
Created attachment 377078 [details] Patch
Saam Barati
Comment 2 2019-08-23 00:59:58 PDT
Comment on attachment 377078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377078&action=review r=me Please also add the new test from Radar > Source/JavaScriptCore/ChangeLog:9 > + to remove it instead of hacking it to fix the most recent false positive. It would be good to describe the latest issue to motivate why it’s not worth keeping > JSTests/stress/set-argument-maybe-maximal-flush-should-not-extend-liveness-2.js:-1 > -//@ runDefault("--useMaximalFlushInsertionPhase=1", "--jitPolicyScale=0", "--useConcurrentJIT=0") Let’s keep these tests and just remove the option
Tadeu Zagallo
Comment 3 2019-08-23 15:25:20 PDT
Created attachment 377163 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-08-23 16:08:13 PDT
Comment on attachment 377163 [details] Patch for landing Clearing flags on attachment: 377163 Committed r249075: <https://trac.webkit.org/changeset/249075>
WebKit Commit Bot
Comment 5 2019-08-23 16:08:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-23 16:09:20 PDT
<rdar://problem/54658790>
Yusuke Suzuki
Comment 7 2019-08-26 13:42:52 PDT
Committed r249116: <https://trac.webkit.org/changeset/249116>
Note You need to log in before you can comment on or make changes to this bug.