In Catalina, we want to opt out of bulk symbolication when calling spindump, since it may prompt the user for credentials.
<rdar://problem/53778938>
Created attachment 376948 [details] Patch
Comment on attachment 376948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376948&action=review > Tools/Scripts/webkitpy/port/darwin.py:181 > + exit_code = host.executive.run_command(spindump_command + ['-noBulkSymbolication'], return_exit_code=True) It looks like the fallback won't be needed once macOS Catalina is the oldest supported version. Please add a comment explaining what's happening here in some reasonable detail (at least a radar link, and a FIXME to remove). That said, I'm not entirely sure which platforms we try to run this on. This is darwin.py, does that mean that this code runs on iOS?
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 376948 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376948&action=review > > > Tools/Scripts/webkitpy/port/darwin.py:181 > > + exit_code = host.executive.run_command(spindump_command + ['-noBulkSymbolication'], return_exit_code=True) > > It looks like the fallback won't be needed once macOS Catalina is the oldest > supported version. Please add a comment explaining what's happening here in > some reasonable detail (at least a radar link, and a FIXME to remove). > > That said, I'm not entirely sure which platforms we try to run this on. This > is darwin.py, does that mean that this code runs on iOS? Yes, this is run on iOS and watchOS too. Both iOS 13 and watchOS 6 have the -noSymbolication flag.
Created attachment 377018 [details] Patch
Comment on attachment 377018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377018&action=review > Tools/Scripts/webkitpy/port/darwin.py:183 > + #FIXME: Remove when we no longer support Catalina This is not right - the time to remove is when macOS Catalina is the oldest supported version, not when we no longer support it. Please add a space after #, and a period at the end of the sentence. I'd also say "remove the fallback", not just "remove".
Created attachment 377023 [details] Patch
Comment on attachment 377023 [details] Patch Clearing flags on attachment: 377023 Committed r249023: <https://trac.webkit.org/changeset/249023>
All reviewed patches have been landed. Closing bug.
Reopening to attach new patch.
Created attachment 377347 [details] Patch
Comment on attachment 377347 [details] Patch Clearing flags on attachment: 377347 Committed r249151: <https://trac.webkit.org/changeset/249151>