RESOLVED FIXED 200995
[WHLSL] Improve default constructor and emit fewer pointers in metal codegen 
https://bugs.webkit.org/show_bug.cgi?id=200995
Summary [WHLSL] Improve default constructor and emit fewer pointers in metal codegen
Saam Barati
Reported 2019-08-21 13:44:35 PDT
It's like an 8% speedup in metal compile time
Attachments
patch (7.64 KB, patch)
2019-08-21 14:05 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-08-21 14:05:53 PDT
Created attachment 376919 [details] patch
Saam Barati
Comment 2 2019-08-21 19:01:07 PDT
Comment on attachment 376919 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=376919&action=review > Source/WebCore/ChangeLog:12 > + 4. Lazily produce lvalues for GlobalVariableReference. I forgot to add a comment her on speedup. Will do.
WebKit Commit Bot
Comment 3 2019-08-21 19:55:38 PDT
Comment on attachment 376919 [details] patch Clearing flags on attachment: 376919 Committed r248994: <https://trac.webkit.org/changeset/248994>
WebKit Commit Bot
Comment 4 2019-08-21 19:55:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-08-21 19:56:20 PDT
<rdar://problem/54583805>
Saam Barati
Comment 6 2019-08-21 20:03:32 PDT
Comment on attachment 376919 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=376919&action=review >> Source/WebCore/ChangeLog:12 >> + 4. Lazily produce lvalues for GlobalVariableReference. > > I forgot to add a comment her on speedup. Will do. This got committed by the commit queue. For posterity, I was seeing a 7-8% speedup in metal compile times with p=0.0001
Note You need to log in before you can comment on or make changes to this bug.