Bug 200995 - [WHLSL] Improve default constructor and emit fewer pointers in metal codegen
Summary: [WHLSL] Improve default constructor and emit fewer pointers in metal codegen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-21 13:44 PDT by Saam Barati
Modified: 2019-08-21 20:03 PDT (History)
9 users (show)

See Also:


Attachments
patch (7.64 KB, patch)
2019-08-21 14:05 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-08-21 13:44:35 PDT
It's like an 8% speedup in metal compile time
Comment 1 Saam Barati 2019-08-21 14:05:53 PDT
Created attachment 376919 [details]
patch
Comment 2 Saam Barati 2019-08-21 19:01:07 PDT
Comment on attachment 376919 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376919&action=review

> Source/WebCore/ChangeLog:12
> +        4. Lazily produce lvalues for GlobalVariableReference.

I forgot to add a comment her on speedup. Will do.
Comment 3 WebKit Commit Bot 2019-08-21 19:55:38 PDT
Comment on attachment 376919 [details]
patch

Clearing flags on attachment: 376919

Committed r248994: <https://trac.webkit.org/changeset/248994>
Comment 4 WebKit Commit Bot 2019-08-21 19:55:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-21 19:56:20 PDT
<rdar://problem/54583805>
Comment 6 Saam Barati 2019-08-21 20:03:32 PDT
Comment on attachment 376919 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376919&action=review

>> Source/WebCore/ChangeLog:12
>> +        4. Lazily produce lvalues for GlobalVariableReference.
> 
> I forgot to add a comment her on speedup. Will do.

This got committed by the commit queue. For posterity, I was seeing a 7-8% speedup in metal compile times with p=0.0001