Bug 200988 - results.webkit.org: Fix drawer style
Summary: results.webkit.org: Fix drawer style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-21 11:15 PDT by Jonathan Bedard
Modified: 2019-08-21 22:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.00 KB, patch)
2019-08-21 14:07 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (4.02 KB, patch)
2019-08-21 21:05 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-08-21 11:15:09 PDT 
There are a number of issues with the drawer style, including incorrect text sizes, underlining links which are actually actions and allowing users to select expandable menu text.
Comment 1 Jonathan Bedard 2019-08-21 14:07:06 PDT 
Created attachment 376920 [details]
Patch
Comment 2 Zhifei Fang 2019-08-21 14:13:15 PDT 
https://bugs.webkit.org/show_bug.cgi?id=200998 this will help you to solve the disabled input text overlay issue that Ryan mentioned.
Comment 3 Zhifei Fang 2019-08-21 14:33:57 PDT 
unofficially r=me
Comment 4 Zhifei Fang 2019-08-21 14:56:21 PDT 
Comment on attachment 376920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376920&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:197
> +.action:hover {

You can change this to name like:  a.link-btn
Comment 5 Aakash Jain 2019-08-21 16:56:29 PDT 
rs=me
Comment 6 Jonathan Bedard 2019-08-21 21:05:48 PDT 
Created attachment 376977 [details]
Patch
Comment 7 WebKit Commit Bot 2019-08-21 22:33:39 PDT 
Comment on attachment 376977 [details]
Patch

Clearing flags on attachment: 376977

Committed r248995: <https://trac.webkit.org/changeset/248995>
Comment 8 WebKit Commit Bot 2019-08-21 22:33:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-08-21 22:34:16 PDT 
<rdar://problem/54586582>