Bug 200982 - [GStreamer] Clang warns about mismatched type tag in declarations for ImageOrientation
Summary: [GStreamer] Clang warns about mismatched type tag in declarations for ImageOr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-21 08:57 PDT by Adrian Perez
Modified: 2019-08-21 10:09 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2019-08-21 09:06 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-08-21 08:57:41 PDT 
In file included from ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:89:
../Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:33:1: warning: class 'ImageOrientation' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]
class ImageOrientation;
^
../Source/WebCore/platform/graphics/ImageOrientation.h:34:8: note: previous use is here
struct ImageOrientation {
       ^
../Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:33:1: note: did you mean struct here?
class ImageOrientation;
^~~~~
struct
1 warning generated.
Comment 1 Adrian Perez 2019-08-21 09:06:07 PDT 
Created attachment 376889 [details]
Patch
Comment 2 WebKit Commit Bot 2019-08-21 10:08:54 PDT 
Comment on attachment 376889 [details]
Patch

Clearing flags on attachment: 376889

Committed r248946: <https://trac.webkit.org/changeset/248946>
Comment 3 WebKit Commit Bot 2019-08-21 10:08:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-08-21 10:09:16 PDT 
<rdar://problem/54560227>