Get rid of m_weakThis data members now that we have a safe way to call makeWeakPtr() from various threads.
Created attachment 376887 [details] Patch
Comment on attachment 376887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376887&action=review > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:49 > +// Use eager initialization for the WeakPtrFactory since we call makeWeakPtr() from another thread. I don't think these comments are necessary.
(In reply to Alex Christensen from comment #2) > Comment on attachment 376887 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376887&action=review > > > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:49 > > +// Use eager initialization for the WeakPtrFactory since we call makeWeakPtr() from another thread. > > I don't think these comments are necessary. I personally think it is important to document why we need eager initialization here so that nobody is tempted to remove it, or so that it can be removed when it is no longer needed. I seem to remember Geoff asking for a comment as well.
Comment on attachment 376887 [details] Patch Clearing flags on attachment: 376887 Committed r248958: <https://trac.webkit.org/changeset/248958>
All reviewed patches have been landed. Closing bug.
<rdar://problem/54567696>