RESOLVED FIXED 200981
Get rid of m_weakThis data members now that we have a safe way to call makeWeakPtr() from various threads 
https://bugs.webkit.org/show_bug.cgi?id=200981
Summary Get rid of m_weakThis data members now that we have a safe way to call makeWe...
Chris Dumez
Reported 2019-08-21 08:51:59 PDT
Get rid of m_weakThis data members now that we have a safe way to call makeWeakPtr() from various threads.
Attachments
Patch (8.90 KB, patch)
2019-08-21 08:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-08-21 08:52:41 PDT
Created attachment 376887 [details] Patch
Alex Christensen
Comment 2 2019-08-21 11:05:10 PDT
Comment on attachment 376887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376887&action=review > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:49 > +// Use eager initialization for the WeakPtrFactory since we call makeWeakPtr() from another thread. I don't think these comments are necessary.
Chris Dumez
Comment 3 2019-08-21 11:10:03 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 376887 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376887&action=review > > > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:49 > > +// Use eager initialization for the WeakPtrFactory since we call makeWeakPtr() from another thread. > > I don't think these comments are necessary. I personally think it is important to document why we need eager initialization here so that nobody is tempted to remove it, or so that it can be removed when it is no longer needed. I seem to remember Geoff asking for a comment as well.
WebKit Commit Bot
Comment 4 2019-08-21 12:51:05 PDT
Comment on attachment 376887 [details] Patch Clearing flags on attachment: 376887 Committed r248958: <https://trac.webkit.org/changeset/248958>
WebKit Commit Bot
Comment 5 2019-08-21 12:51:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-21 12:52:18 PDT
<rdar://problem/54567696>
Note You need to log in before you can comment on or make changes to this bug.