RESOLVED FIXED 200980
Add internal setting to disable SecureContext checks 
https://bugs.webkit.org/show_bug.cgi?id=200980
Summary Add internal setting to disable SecureContext checks
Chris Dumez
Reported 2019-08-21 08:42:14 PDT
Add internal setting to disable SecureContext checks, in order to facilitate development for features like Service workers or device orientation / motion.
Attachments
Patch (11.87 KB, patch)
2019-08-21 08:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.09 KB, patch)
2019-08-21 08:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-08-21 08:42:28 PDT
<rdar://problem/54438512>
Chris Dumez
Comment 2 2019-08-21 08:44:44 PDT
Created attachment 376886 [details] Patch
EWS Watchlist
Comment 3 2019-08-21 08:47:08 PDT
Attachment 376886 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:305: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:313: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:320: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:345: More than one command on the same line [whitespace/newline] [4] Total errors found: 4 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4 2019-08-21 08:55:49 PDT
Created attachment 376888 [details] Patch
EWS Watchlist
Comment 5 2019-08-21 08:57:03 PDT
Attachment 376888 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:305: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:313: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:320: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:345: More than one command on the same line [whitespace/newline] [4] Total errors found: 4 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 6 2019-08-21 11:08:25 PDT
Comment on attachment 376888 [details] Patch Why don't you just use TCPServer with HTTPS or HTTPSProxy? Then we wouldn't have to add a way to disable important security checks.
Chris Dumez
Comment 7 2019-08-21 11:37:23 PDT
(In reply to Alex Christensen from comment #6) > Comment on attachment 376888 [details] > Patch > > Why don't you just use TCPServer with HTTPS or HTTPSProxy? Then we wouldn't > have to add a way to disable important security checks. Please look at the radar.
WebKit Commit Bot
Comment 8 2019-08-21 12:36:41 PDT
Comment on attachment 376888 [details] Patch Clearing flags on attachment: 376888 Committed r248957: <https://trac.webkit.org/changeset/248957>
WebKit Commit Bot
Comment 9 2019-08-21 12:36:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.