Bug 200980 - Add internal setting to disable SecureContext checks
Summary: Add internal setting to disable SecureContext checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-21 08:42 PDT by Chris Dumez
Modified: 2019-08-21 12:36 PDT (History)
9 users (show)

See Also:


Attachments
Patch (11.87 KB, patch)
2019-08-21 08:44 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (12.09 KB, patch)
2019-08-21 08:55 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-08-21 08:42:14 PDT
Add internal setting to disable SecureContext checks, in order to facilitate development for features like Service workers or device orientation / motion.
Comment 1 Chris Dumez 2019-08-21 08:42:28 PDT
<rdar://problem/54438512>
Comment 2 Chris Dumez 2019-08-21 08:44:44 PDT
Created attachment 376886 [details]
Patch
Comment 3 EWS Watchlist 2019-08-21 08:47:08 PDT
Attachment 376886 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:305:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:313:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:320:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:345:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2019-08-21 08:55:49 PDT
Created attachment 376888 [details]
Patch
Comment 5 EWS Watchlist 2019-08-21 08:57:03 PDT
Attachment 376888 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:305:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:313:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:320:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:345:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alex Christensen 2019-08-21 11:08:25 PDT
Comment on attachment 376888 [details]
Patch

Why don't you just use TCPServer with HTTPS or HTTPSProxy?  Then we wouldn't have to add a way to disable important security checks.
Comment 7 Chris Dumez 2019-08-21 11:37:23 PDT
(In reply to Alex Christensen from comment #6)
> Comment on attachment 376888 [details]
> Patch
> 
> Why don't you just use TCPServer with HTTPS or HTTPSProxy?  Then we wouldn't
> have to add a way to disable important security checks.

Please look at the radar.
Comment 8 WebKit Commit Bot 2019-08-21 12:36:41 PDT
Comment on attachment 376888 [details]
Patch

Clearing flags on attachment: 376888

Committed r248957: <https://trac.webkit.org/changeset/248957>
Comment 9 WebKit Commit Bot 2019-08-21 12:36:43 PDT
All reviewed patches have been landed.  Closing bug.