Bug 200972 - [GStreamer] Hole-punch build is broken
Summary: [GStreamer] Hole-punch build is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-21 03:17 PDT by Philippe Normand
Modified: 2019-08-23 03:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2019-08-21 03:23 PDT, Philippe Normand 		zan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-08-21 03:17:54 PDT 
I'm not landing the fix directly because I'm not sure it's the right approach.
Comment 1 Philippe Normand 2019-08-21 03:23:48 PDT 
Created attachment 376859 [details]
Patch
Comment 2 Zan Dobersek 2019-08-23 03:38:11 PDT 
Comment on attachment 376859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376859&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:72
>          virtual void setVideoRectangle(const IntRect&) = 0;
> -        virtual ~HolePunchClient() = 0;
> +        virtual ~HolePunchClient() = default;

Nit: the destructor should be placed first.
Comment 3 Philippe Normand 2019-08-23 03:53:18 PDT 
Committed r249043: <https://trac.webkit.org/changeset/249043>
Comment 4 Radar WebKit Bug Importer 2019-08-23 03:54:19 PDT 
<rdar://problem/54635405>