Bug 200969 – Web Inspector: Provide an engineering option to log protocol traffic as text

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Provide an engineering option to log protocol traffic as text

This makes the protocol traffic easier to copy/paste and filter.

[Joseph Pecoraro]

Created attachment 376853 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 376853 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=376853&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:387
> +        debuggingGroup.addSetting(WI.settings.engineeringLogProtocolAsText, WI.unlocalizedString("Log Protocol as Text"));

I'd put this in a "Protocol Logging:" section to match what's there in the Debug pane.

[Joseph Pecoraro]

> > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:387
> > +        debuggingGroup.addSetting(WI.settings.engineeringLogProtocolAsText, WI.unlocalizedString("Log Protocol as Text"));
> 
> I'd put this in a "Protocol Logging:" section to match what's there in the
> Debug pane.

Good idea. I moved this into the `protocol` variables and Debug section as "Log as Text".

[Joseph Pecoraro]

Created attachment 377014 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 377014 [details]
[PATCH] For Landing

Clearing flags on attachment: 377014

Committed r249014: <https://trac.webkit.org/changeset/249014>

[Radar WebKit Bug Importer]

<rdar://problem/54628714>