Bug 200969 - Web Inspector: Provide an engineering option to log protocol traffic as text
Summary: Web Inspector: Provide an engineering option to log protocol traffic as text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-21 01:20 PDT by Joseph Pecoraro
Modified: 2019-08-22 22:04 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.65 KB, patch)
2019-08-21 01:21 PDT, Joseph Pecoraro 		hi: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (3.25 KB, patch)
2019-08-22 09:01 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-08-21 01:20:48 PDT 
Provide an engineering option to log protocol traffic as text

This makes the protocol traffic easier to copy/paste and filter.
Comment 1 Joseph Pecoraro 2019-08-21 01:21:27 PDT 
Created attachment 376853 [details]
[PATCH] Proposed Fix
Comment 2 Devin Rousso 2019-08-21 02:36:55 PDT 
Comment on attachment 376853 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=376853&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:387
> +        debuggingGroup.addSetting(WI.settings.engineeringLogProtocolAsText, WI.unlocalizedString("Log Protocol as Text"));

I'd put this in a "Protocol Logging:" section to match what's there in the Debug pane.
Comment 3 Joseph Pecoraro 2019-08-22 09:00:44 PDT 
> > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:387
> > +        debuggingGroup.addSetting(WI.settings.engineeringLogProtocolAsText, WI.unlocalizedString("Log Protocol as Text"));
> 
> I'd put this in a "Protocol Logging:" section to match what's there in the
> Debug pane.

Good idea. I moved this into the `protocol` variables and Debug section as "Log as Text".
Comment 4 Joseph Pecoraro 2019-08-22 09:01:17 PDT 
Created attachment 377014 [details]
[PATCH] For Landing
Comment 5 WebKit Commit Bot 2019-08-22 09:43:04 PDT 
Comment on attachment 377014 [details]
[PATCH] For Landing

Clearing flags on attachment: 377014

Committed r249014: <https://trac.webkit.org/changeset/249014>
Comment 6 Radar WebKit Bug Importer 2019-08-22 22:04:39 PDT 
<rdar://problem/54628714>