Bug 200965 - JSTests/stress/optional-chaining should not call shouldThrowTypeError in a loop
Summary: JSTests/stress/optional-chaining should not call shouldThrowTypeError in a loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-20 20:50 PDT by Ross Kirsling
Modified: 2019-08-21 12:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.04 KB, patch)
2019-08-20 20:54 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch for landing (2.38 KB, patch)
2019-08-21 11:33 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2019-08-20 20:50:03 PDT
JSTests/stress/optional-chaining should not call shouldThrowTypeError in a loop
Comment 1 Ross Kirsling 2019-08-20 20:54:11 PDT
Created attachment 376842 [details]
Patch
Comment 2 Saam Barati 2019-08-21 09:37:34 PDT
Comment on attachment 376842 [details]
Patch

Maybe run them in a shorter loop so they hit the JITs in eager tests at least? Maybe a loop with 100 iterations?
Comment 3 Ross Kirsling 2019-08-21 11:31:59 PDT
(In reply to Saam Barati from comment #2)
> Comment on attachment 376842 [details]
> Patch
> 
> Maybe run them in a shorter loop so they hit the JITs in eager tests at
> least? Maybe a loop with 100 iterations?

Works for me.
Comment 4 Ross Kirsling 2019-08-21 11:33:19 PDT
Created attachment 376898 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-08-21 12:17:20 PDT
Comment on attachment 376898 [details]
Patch for landing

Clearing flags on attachment: 376898

Committed r248955: <https://trac.webkit.org/changeset/248955>
Comment 6 WebKit Commit Bot 2019-08-21 12:17:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-21 12:18:18 PDT
<rdar://problem/54566510>