Bug 200961 - [WHLSL] We can not do effects for ternary expressions and logical expressions eagerly
Summary: [WHLSL] We can not do effects for ternary expressions and logical expressions...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-20 19:12 PDT by Saam Barati
Modified: 2020-05-05 00:42 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-08-20 19:12:00 PDT 
We just emit before the branch for ternary and the implicit branch for logical expressions.

So if we had something like:
(b ? a[0] = 1 : a[1] = 2)

we'd store both to a[0] and a[1]
Comment 1 Myles C. Maxfield 2019-08-21 17:19:02 PDT 
same with || and &&
Comment 2 Saam Barati 2019-09-04 20:32:55 PDT 
I believe I did this as a consequence of my removal of getters/setters/anders. We should just add tests for that in this bug.
Comment 3 Myles C. Maxfield 2020-05-05 00:42:41 PDT 
WHLSL is no longer relevant.