Bug 200958 - Remove superfluous size argument to allocateCell() for fixed size objects.
Summary: Remove superfluous size argument to allocateCell() for fixed size objects.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-20 18:06 PDT by Mark Lam
Modified: 2019-08-20 18:14 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch. (10.04 KB, patch)
2019-08-20 18:09 PDT, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-08-20 18:06:53 PDT
The size is already automatically computed by the allocateCell() template's default arguments.  Removing these superfluous arguments will make it easier for us to grep for cases where we allocate variable size cells (for later analysis work).
Comment 1 Mark Lam 2019-08-20 18:09:45 PDT
Created attachment 376835 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2019-08-20 18:11:16 PDT
Comment on attachment 376835 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2019-08-20 18:13:40 PDT
Thanks for the review.  Landed in r248929: <http://trac.webkit.org/r248929>.
Comment 4 Radar WebKit Bug Importer 2019-08-20 18:14:23 PDT
<rdar://problem/54537825>