Bug 200956 - JSBigInt::m_length should be immutable.
Summary: JSBigInt::m_length should be immutable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-20 17:32 PDT by Mark Lam
Modified: 2019-08-20 17:40 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch. (1.88 KB, patch)
2019-08-20 17:35 PDT, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-08-20 17:32:11 PDT
This is because the JSBigInt cell size is allocated with that length.  Changing the length after construction does not change the size of the cell, and hence, makes no sense.
Comment 1 Mark Lam 2019-08-20 17:35:42 PDT
Created attachment 376832 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2019-08-20 17:37:04 PDT
Comment on attachment 376832 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2019-08-20 17:39:38 PDT
Thanks for the review.  Landed in r248927: <http://trac.webkit.org/r248927>.
Comment 4 Radar WebKit Bug Importer 2019-08-20 17:40:19 PDT
<rdar://problem/54536646>