Bug 200942 - Web Inspector: Update CodeMirror to support numeric separators in JavaScript numbers
Summary: Web Inspector: Update CodeMirror to support numeric separators in JavaScript ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-20 14:27 PDT by Joseph Pecoraro
Modified: 2019-08-20 16:45 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.58 KB, patch)
2019-08-20 14:28 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] Before (300.10 KB, image/png)
2019-08-20 14:34 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] After (300.47 KB, image/png)
2019-08-20 14:34 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-08-20 14:27:52 PDT 
Update CodeMirror to support numeric separators in JavaScript numbers

Steps to Reproduce:
1. js> 1_000
  => Doesn't syntax highlight as expected

Cherry-pick:

    [javascript mode] Support numeric separators
    https://github.com/codemirror/CodeMirror/commit/beab8ed123683416bfec934df73d13401ec086b5#diff-9812850bb71d31e8dd60b476abb2bae8

    [javascript mode] fix tokenizing of underscore properties
    https://github.com/codemirror/CodeMirror/commit/463ea2c34ab442c0cae1d9732305219ca9b04dfe#diff-9812850bb71d31e8dd60b476abb2bae8
Comment 1 Joseph Pecoraro 2019-08-20 14:28:57 PDT 
Created attachment 376805 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2019-08-20 14:34:41 PDT 
Created attachment 376807 [details]
[IMAGE] Before
Comment 3 Joseph Pecoraro 2019-08-20 14:34:52 PDT 
Created attachment 376808 [details]
[IMAGE] After
Comment 4 WebKit Commit Bot 2019-08-20 16:44:45 PDT 
Comment on attachment 376805 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 376805

Committed r248922: <https://trac.webkit.org/changeset/248922>
Comment 5 WebKit Commit Bot 2019-08-20 16:44:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-20 16:45:19 PDT 
<rdar://problem/54534515>