Bug 200940 - Web Inspector: Sources: increase the filter bar's width when it's focused if a resource type filter is active
Summary: Web Inspector: Sources: increase the filter bar's width when it's focused if ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 200891
Blocks:
  Show dependency treegraph
 
Reported: 2019-08-20 13:03 PDT by Devin Rousso
Modified: 2019-08-21 03:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (17.35 KB, patch)
2019-08-20 22:20 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Video] After Patch is applied (282.88 KB, video/quicktime)
2019-08-20 22:20 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-08-20 13:03:49 PDT
From <https://webkit.org/b/200891#c3>:
> • I think we will want to better handle filtering at the bottom if a long name filter like "Documents" is selected. Perhaps hiding the fields when clicking into the filter field.
Comment 1 Devin Rousso 2019-08-20 22:20:20 PDT
Created attachment 376844 [details]
Patch
Comment 2 Devin Rousso 2019-08-20 22:20:39 PDT
Created attachment 376845 [details]
[Video] After Patch is applied
Comment 3 Joseph Pecoraro 2019-08-21 00:01:03 PDT
Comment on attachment 376844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376844&action=review

rs=me. Video looks great!!

> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:91
> +/* FIXME: use a different image for ::-webkit-search-decoration when :not(:placeholder-shown) */

Still needed?
Comment 4 Devin Rousso 2019-08-21 02:48:14 PDT
Comment on attachment 376844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376844&action=review

>> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:91
>> +/* FIXME: use a different image for ::-webkit-search-decoration when :not(:placeholder-shown) */
> 
> Still needed?

Yes, sadly :(

There doesn't seem to be a way to access `--glyph-color-active` (which maps to `-apple-system-control-accent`) from within a SVG file, which is what we'd want given that the rest of the UI matches the system accent.
Comment 5 WebKit Commit Bot 2019-08-21 03:31:04 PDT
Comment on attachment 376844 [details]
Patch

Clearing flags on attachment: 376844

Committed r248940: <https://trac.webkit.org/changeset/248940>
Comment 6 WebKit Commit Bot 2019-08-21 03:31:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-21 03:32:16 PDT
<rdar://problem/54549231>