Bug 200926 - [ContentChangeObserver] isConsideredClickable should be able to process elements with no renderers
Summary: [ContentChangeObserver] isConsideredClickable should be able to process eleme...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-20 11:09 PDT by zalan
Modified: 2019-08-20 11:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.31 KB, patch)
2019-08-20 11:14 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.30 KB, patch)
2019-08-20 11:34 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-08-20 11:09:32 PDT 
when going from visible -> hidden.
Comment 1 Radar WebKit Bug Importer 2019-08-20 11:09:54 PDT 
<rdar://problem/54519579>
Comment 2 zalan 2019-08-20 11:14:35 PDT 
Created attachment 376784 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-08-20 11:20:15 PDT 
Comment on attachment 376784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376784&action=review

> Source/WebCore/ChangeLog:7
> +        Now that ContentChangeObserver tracks visible->hidden changes, isConsideredClickable should be able to deal with elemenets with no renderers. 

elemenets. You should say that this is fixing a crash (not just via the test case name).
Comment 4 zalan 2019-08-20 11:34:31 PDT 
Created attachment 376786 [details]
Patch
Comment 5 WebKit Commit Bot 2019-08-20 11:58:18 PDT 
Comment on attachment 376786 [details]
Patch

Clearing flags on attachment: 376786

Committed r248911: <https://trac.webkit.org/changeset/248911>
Comment 6 WebKit Commit Bot 2019-08-20 11:58:20 PDT 
All reviewed patches have been landed.  Closing bug.