Bug 200917 – Do not call addHTTPOriginIfNeeded for window.open

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Rob Buis]

Avoid spurious image downloads.

[Rob Buis]

Created attachment 376762 [details]
Patch

[EWS Watchlist]

Comment on attachment 376762 [details]
Patch

Attachment 376762 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12946532

New failing tests:
http/tests/misc/image-blocked-src-no-change.html

[EWS Watchlist]

Created attachment 376764 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 376762 [details]
Patch

Attachment 376762 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12946565

New failing tests:
http/tests/misc/image-blocked-src-no-change.html

[EWS Watchlist]

Created attachment 376766 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 376762 [details]
Patch

Attachment 376762 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12946620

New failing tests:
http/tests/misc/image-blocked-src-no-change.html

[EWS Watchlist]

Created attachment 376767 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Rob Buis]

Created attachment 377210 [details]
Patch

[Rob Buis]

Created attachment 377212 [details]
Patch

[youenn fablet]

Comment on attachment 377212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377212&action=review

> Source/WebCore/loader/FrameLoader.cpp:-4097
> -    FrameLoader::addHTTPOriginIfNeeded(request.resourceRequest(), openerFrame.loader().outgoingOrigin());

What guarantees do we have that request.resourceRequest() is GET and not POST?

> Source/WebCore/page/DOMWindow.cpp:-2360
> -    FrameLoader::addHTTPOriginIfNeeded(resourceRequest, firstFrame.loader().outgoingOrigin());

Seems fine.

[Rob Buis]

(In reply to youenn fablet from comment #10)
> Comment on attachment 377212 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377212&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:-4097
> > -    FrameLoader::addHTTPOriginIfNeeded(request.resourceRequest(), openerFrame.loader().outgoingOrigin());
> 
> What guarantees do we have that request.resourceRequest() is GET and not
> POST?

The only other user of WebCore::createWindow that I can find is InspectorFrontendClientLocal::openInNewTab, which uses an empty ResourceRequest. I assumed empty ResourceRequest would default to GET, which it does not, so I'll remove this part of the patch.

[Rob Buis]

Created attachment 377242 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 377242 [details]
Patch

Change to Source/WebCore/loader/FrameLoader.cpp has been removed and Youenn already approved the one from Source/WebCore/page/DOMWindow.cpp.

[WebKit Commit Bot]

Comment on attachment 377242 [details]
Patch

Clearing flags on attachment: 377242

Committed r249253: <https://trac.webkit.org/changeset/249253>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54831486>