Bug 200908 - [WHLSL] Only take the pointer of a variable or global variable reference if it is used
Summary: [WHLSL] Only take the pointer of a variable or global variable reference if i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-19 19:43 PDT by Saam Barati
Modified: 2019-08-20 10:20 PDT (History)
9 users (show)

See Also:


Attachments
patch (7.70 KB, patch)
2019-08-19 22:09 PDT, Saam Barati
dino: review+
saam: commit-queue-
Details | Formatted Diff | Diff
patch for landing (7.71 KB, patch)
2019-08-20 00:01 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-08-19 19:43:30 PDT
This is a 7% compile time speedup in Metal for compute_boids
Comment 1 Saam Barati 2019-08-19 22:09:09 PDT
Created attachment 376745 [details]
patch
Comment 2 Saam Barati 2019-08-20 00:01:25 PDT
Created attachment 376750 [details]
patch for landing
Comment 3 WebKit Commit Bot 2019-08-20 10:19:11 PDT
Comment on attachment 376750 [details]
patch for landing

Clearing flags on attachment: 376750

Committed r248904: <https://trac.webkit.org/changeset/248904>
Comment 4 WebKit Commit Bot 2019-08-20 10:19:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-20 10:20:22 PDT
<rdar://problem/54516963>