Bug 200905 - [JSC] Array.prototype.toString should not get "join" function each time
Summary: [JSC] Array.prototype.toString should not get "join" function each time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-19 17:20 PDT by Yusuke Suzuki
Modified: 2019-08-20 10:37 PDT (History)
7 users (show)

See Also:

Attachments
Patch (29.02 KB, patch)
2019-08-20 02:03 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (29.00 KB, patch)
2019-08-20 02:06 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (29.05 KB, patch)
2019-08-20 02:09 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (29.06 KB, patch)
2019-08-20 02:15 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (29.29 KB, patch)
2019-08-20 02:18 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-08-19 17:20:28 PDT 
We should avoid it by setting watchpoint.
Comment 1 Yusuke Suzuki 2019-08-20 02:03:10 PDT 
Created attachment 376754 [details]
Patch
Comment 2 Yusuke Suzuki 2019-08-20 02:06:30 PDT 
Created attachment 376755 [details]
Patch
Comment 3 Yusuke Suzuki 2019-08-20 02:09:30 PDT 
Created attachment 376756 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2019-08-20 02:15:21 PDT 
<rdar://problem/54503629>
Comment 5 Yusuke Suzuki 2019-08-20 02:15:36 PDT 
Created attachment 376757 [details]
Patch
Comment 6 Yusuke Suzuki 2019-08-20 02:18:26 PDT 
Created attachment 376758 [details]
Patch
Comment 7 Mark Lam 2019-08-20 07:48:43 PDT 
Comment on attachment 376758 [details]
Patch

Where is the code that fires arrayJoinWatchpointSet()?
Comment 8 Yusuke Suzuki 2019-08-20 09:44:58 PDT 
(In reply to Mark Lam from comment #7)
> Comment on attachment 376758 [details]
> Patch
> 
> Where is the code that fires arrayJoinWatchpointSet()?

ObjectPropertyChangeAdaptiveWatchpoint is created for this watchpointset. It will fire.
Comment 9 Mark Lam 2019-08-20 09:50:01 PDT 
(In reply to Yusuke Suzuki from comment #8)
> (In reply to Mark Lam from comment #7)
> > Comment on attachment 376758 [details]
> > Patch
> > 
> > Where is the code that fires arrayJoinWatchpointSet()?
> 
> ObjectPropertyChangeAdaptiveWatchpoint is created for this watchpointset. It
> will fire.

Ah, I see.  I missed that.
Comment 10 Mark Lam 2019-08-20 09:50:17 PDT 
Comment on attachment 376758 [details]
Patch

r=me
Comment 11 Yusuke Suzuki 2019-08-20 10:37:11 PDT 
Committed r248906: <https://trac.webkit.org/changeset/248906>