Bug 200879 - PendingActivationMediaStream does not need to be refcounted
Summary: PendingActivationMediaStream does not need to be refcounted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-19 01:01 PDT by youenn fablet
Modified: 2019-08-20 02:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.08 KB, patch)
2019-08-19 01:02 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (4.06 KB, patch)
2019-08-19 08:19 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2019-08-19 09:36 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.19 KB, patch)
2019-08-20 01:36 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-08-19 01:01:33 PDT 
PendingActivationMediaStream does not need to be refcounted
Comment 1 youenn fablet 2019-08-19 01:02:49 PDT 
Created attachment 376673 [details]
Patch
Comment 2 youenn fablet 2019-08-19 01:26:59 PDT 
Will use WTF::makeUnique.
Comment 3 youenn fablet 2019-08-19 07:51:52 PDT 
Comment on attachment 376673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376673&action=review

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:398
> +    m_pendingActivationMediaStream = nullptr;

No need to do this anymore sine observer handles this properly.
Comment 4 youenn fablet 2019-08-19 08:19:06 PDT 
Created attachment 376686 [details]
Patch
Comment 5 youenn fablet 2019-08-19 09:36:04 PDT 
Created attachment 376692 [details]
Patch
Comment 6 WebKit Commit Bot 2019-08-19 11:28:19 PDT 
Comment on attachment 376692 [details]
Patch

Rejecting attachment 376692 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 376692, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file.

Full output: https://webkit-queues.webkit.org/results/12941867
Comment 7 youenn fablet 2019-08-20 01:36:52 PDT 
Created attachment 376752 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-08-20 02:39:31 PDT 
Comment on attachment 376752 [details]
Patch for landing

Clearing flags on attachment: 376752

Committed r248896: <https://trac.webkit.org/changeset/248896>
Comment 9 WebKit Commit Bot 2019-08-20 02:39:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-08-20 02:40:18 PDT 
<rdar://problem/54504227>