Bug 200879 – PendingActivationMediaStream does not need to be refcounted

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

PendingActivationMediaStream does not need to be refcounted

[youenn fablet]

Created attachment 376673 [details]
Patch

[youenn fablet]

Will use WTF::makeUnique.

[youenn fablet]

Comment on attachment 376673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376673&action=review

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:398
> +    m_pendingActivationMediaStream = nullptr;

No need to do this anymore sine observer handles this properly.

[youenn fablet]

Created attachment 376686 [details]
Patch

[youenn fablet]

Created attachment 376692 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 376692 [details]
Patch

Rejecting attachment 376692 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 376692, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file.

Full output: https://webkit-queues.webkit.org/results/12941867

[youenn fablet]

Created attachment 376752 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 376752 [details]
Patch for landing

Clearing flags on attachment: 376752

Committed r248896: <https://trac.webkit.org/changeset/248896>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54504227>