Bug 200874 – Web Inspector: Debugger: pause on assertion failures breakpoint doesn't work when inspecting a JSContext

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Devin Rousso]

Created attachment 376660 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 376660 [details]
Patch

Very nice! r=me

[WebKit Commit Bot]

Comment on attachment 376660 [details]
Patch

Rejecting attachment 376660 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 376660, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=376660&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=200874&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 376660 from bug 200874.
Fetching: https://bugs.webkit.org/attachment.cgi?id=376660
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp
Hunk #1 FAILED at 68.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12944423

[Devin Rousso]

Created attachment 376743 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 376743 [details]
Patch

Clearing flags on attachment: 376743

Committed r248891: <https://trac.webkit.org/changeset/248891>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54498932>