Bug 200873 - Web Inspector: RTL: Network headers values should be preserved
Summary: Web Inspector: RTL: Network headers values should be preserved
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-18 16:33 PDT by Nikita Vasilyev
Modified: 2019-08-19 21:11 PDT (History)
4 users (show)

See Also:


Attachments
[Image] Bug (174.15 KB, image/png)
2019-08-18 16:33 PDT, Nikita Vasilyev
no flags Details
Patch (1.85 KB, patch)
2019-08-18 16:47 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] With patch applied (175.09 KB, image/png)
2019-08-18 16:48 PDT, Nikita Vasilyev
no flags Details
Patch (1.86 KB, patch)
2019-08-18 18:53 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-08-18 16:33:42 PDT
Created attachment 376652 [details]
[Image] Bug

In Network tab, header output is garbled.

    Referer: https://webkit.org/
    ETag: "5c8-58ccda9ff599c"

Became:

    /Referer: https://webkit.org
    "ETag: "5c8-58ccda9ff599c

This affects Headers and Security panels.
Comment 1 Nikita Vasilyev 2019-08-18 16:47:50 PDT
Created attachment 376653 [details]
Patch

We should use <bdi> for cases like this:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/bdi
Comment 2 Nikita Vasilyev 2019-08-18 16:48:56 PDT
Created attachment 376654 [details]
[Image] With patch applied
Comment 3 Nikita Vasilyev 2019-08-18 18:53:45 PDT
Created attachment 376658 [details]
Patch
Comment 4 Joseph Pecoraro 2019-08-19 20:40:30 PDT
Comment on attachment 376658 [details]
Patch

Nice. r=me
Comment 5 WebKit Commit Bot 2019-08-19 21:10:45 PDT
Comment on attachment 376658 [details]
Patch

Clearing flags on attachment: 376658

Committed r248889: <https://trac.webkit.org/changeset/248889>
Comment 6 WebKit Commit Bot 2019-08-19 21:10:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-19 21:11:16 PDT
<rdar://problem/54497737>