WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
200872
[WHLSL] Consider moving as much work from prepare() into createShaderModule as possible
https://bugs.webkit.org/show_bug.cgi?id=200872
Summary
[WHLSL] Consider moving as much work from prepare() into createShaderModule a...
Myles C. Maxfield
Reported
2019-08-18 15:00:59 PDT
Presumably, we could put almost all the processing of prepareShared() inside createShaderModule(). This could be an optimization on some content which reuses shader modules among multiple pipelines. When we try to merge two modules (when creating a render pipeline), we'll have to have a story about duplicate standard library functions. We can do one of the following: 1) Defer standard library processing until this step, and do it once regardless of the number of shader modules are being joined. This means less work is being done up front inside createShaderModule(), which makes the optimization less powerful. 2) Perform standard library processing in createShaderModule(), and make pipeline creation smart enough to de-duplicate standard library functions. 3) Simply allow duplicate standard library functions. This would likely increase Metal's compile times. 4) Keep it the way it is, and have shader modules be a thin wrapper around strings.
Attachments
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2020-05-05 00:42:45 PDT
WHLSL is no longer relevant.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug