Bug 200866 - Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
Summary: Layout tests that call resizeTo() crash when run on iOS with IOSurface suppor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-17 18:39 PDT by Tim Horton
Modified: 2019-08-17 22:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.03 KB, patch)
2019-08-17 18:39 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-08-17 18:39:27 PDT 
Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
Comment 1 Tim Horton 2019-08-17 18:39:48 PDT 
Created attachment 376625 [details]
Patch
Comment 2 Tim Horton 2019-08-17 18:39:50 PDT 
<rdar://problem/50254021>
Comment 3 Alexey Proskuryakov 2019-08-17 22:15:00 PDT 
Comment on attachment 376625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376625&action=review

> Source/WebKit/ChangeLog:15
> +        except for in tests! So just pass the rects straight through, instead of

Or just skip all those tests? Are they meaningful?
Comment 4 Tim Horton 2019-08-17 22:33:07 PDT 
I think it’s ok that a test resizes the “window” in order to resize the view, and it is incidental to the thing the test is actually testing, so it would be weird to skip it. Also possible there are other tests we can unskip now, I have to check.
Comment 5 WebKit Commit Bot 2019-08-17 22:35:50 PDT 
Comment on attachment 376625 [details]
Patch

Clearing flags on attachment: 376625

Committed r248828: <https://trac.webkit.org/changeset/248828>
Comment 6 WebKit Commit Bot 2019-08-17 22:35:51 PDT 
All reviewed patches have been landed.  Closing bug.