Bug 200847 - [WHLSL] Enums should be shadowed by local variables
Summary: [WHLSL] Enums should be shadowed by local variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-16 18:56 PDT by Myles C. Maxfield
Modified: 2019-08-16 21:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.68 KB, patch)
2019-08-16 18:58 PDT, Myles C. Maxfield 		saam: review+
saam: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (5.90 KB, patch)
2019-08-16 19:35 PDT, Myles C. Maxfield 		mmaxfield: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (5.89 KB, patch)
2019-08-16 19:36 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews210 for win-future (13.44 MB, application/zip)
2019-08-16 20:51 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2019-08-16 18:56:27 PDT 
...
Comment 1 Myles C. Maxfield 2019-08-16 18:58:13 PDT 
Created attachment 376575 [details]
Patch
Comment 2 Myles C. Maxfield 2019-08-16 18:58:35 PDT 
https://github.com/gpuweb/WHLSL/issues/312
Comment 3 Saam Barati 2019-08-16 19:11:26 PDT 
Comment on attachment 376575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376575&action=review

r=me

> LayoutTests/webgpu/whlsl/structure-field-enumeration-element-clash.html:25
> +

can you add a checkFail like:

```
    void foo() { variable.x; }
```
Comment 4 Myles C. Maxfield 2019-08-16 19:35:21 PDT 
Created attachment 376581 [details]
Patch for committing
Comment 5 Myles C. Maxfield 2019-08-16 19:36:28 PDT 
Created attachment 376582 [details]
Patch for committing
Comment 6 WebKit Commit Bot 2019-08-16 20:03:42 PDT 
Comment on attachment 376582 [details]
Patch for committing

Clearing flags on attachment: 376582

Committed r248812: <https://trac.webkit.org/changeset/248812>
Comment 7 EWS Watchlist 2019-08-16 20:51:09 PDT 
Comment on attachment 376575 [details]
Patch

Attachment 376575 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12929115

New failing tests:
js/error-should-not-strong-reference-global-object.html
Comment 8 EWS Watchlist 2019-08-16 20:51:11 PDT 
Created attachment 376589 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 9 Radar WebKit Bug Importer 2019-08-16 21:03:23 PDT 
<rdar://problem/54419248>