Bug 200837 - Add John W as a reviewer
Summary: Add John W as a reviewer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-16 15:59 PDT by John Wilander
Modified: 2019-08-16 16:53 PDT (History)
2 users (show)

See Also:

Attachments
Patch for landing (1.22 KB, patch)
2019-08-16 16:01 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Patch for landing (1.24 KB, patch)
2019-08-16 16:08 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-08-16 15:59:42 PDT 
My local config is borked and deleting and re-downloading the repo didn't fix it so I need this bug to be able to land through the commit queue. :/
Comment 1 John Wilander 2019-08-16 16:01:03 PDT 
Created attachment 376555 [details]
Patch for landing
Comment 2 WebKit Commit Bot 2019-08-16 16:03:37 PDT 
Comment on attachment 376555 [details]
Patch for landing

Rejecting attachment 376555 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 376555, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/12927658
Comment 3 John Wilander 2019-08-16 16:08:36 PDT 
Created attachment 376556 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-08-16 16:51:28 PDT 
Comment on attachment 376556 [details]
Patch for landing

Clearing flags on attachment: 376556

Committed r248803: <https://trac.webkit.org/changeset/248803>
Comment 5 WebKit Commit Bot 2019-08-16 16:51:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-16 16:53:45 PDT 
<rdar://problem/54413519>