Bug 200830 - [macOS] Emoji with variation selectors are rendered in text style, not emoji style
Summary: [macOS] Emoji with variation selectors are rendered in text style, not emoji ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-16 13:55 PDT by Myles C. Maxfield
Modified: 2019-08-17 11:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.33 KB, patch)
2019-08-16 13:58 PDT, Myles C. Maxfield 		simon.fraser: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (13.57 MB, application/zip)
2019-08-16 15:35 PDT, EWS Watchlist 		no flags Details
Patch for commit (4.72 KB, patch)
2019-08-16 19:44 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2019-08-16 13:55:43 PDT 
Emoji with variation selectors are rendered in text style, not emoji style
Comment 1 Myles C. Maxfield 2019-08-16 13:58:05 PDT 
Created attachment 376534 [details]
Patch
Comment 2 Myles C. Maxfield 2019-08-16 14:01:20 PDT 
<rdar://problem/53076002>
Comment 3 Simon Fraser (smfr) 2019-08-16 14:08:47 PDT 
Comment on attachment 376534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376534&action=review

> Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:65
> +        if (glyphs[i * glyphStep] && glyphs[i * glyphStep] != 0xFFFF) {

Can we make a constexpr for 0xFFFF please?
Comment 4 EWS Watchlist 2019-08-16 15:35:27 PDT 
Comment on attachment 376534 [details]
Patch

Attachment 376534 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12927172

New failing tests:
fast/text/emoji-variation-selector.html
Comment 5 EWS Watchlist 2019-08-16 15:35:29 PDT 
Created attachment 376546 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 Myles C. Maxfield 2019-08-16 19:44:42 PDT 
Created attachment 376583 [details]
Patch for commit
Comment 7 WebKit Commit Bot 2019-08-16 21:38:51 PDT 
Comment on attachment 376583 [details]
Patch for commit

Clearing flags on attachment: 376583

Committed r248815: <https://trac.webkit.org/changeset/248815>
Comment 8 Darin Adler 2019-08-17 11:26:01 PDT 
Comment on attachment 376583 [details]
Patch for commit

View in context: https://bugs.webkit.org/attachment.cgi?id=376583&action=review

> Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:50
> +static const constexpr CGGlyph deletedGlyph = 0xFFFF;

Something to explore for future coding style purposes:

I think that "constexpr" is sufficient here alone, and "static const" don’t add any useful additional semantics or behavior.