Bug 200830 – [macOS] Emoji with variation selectors are rendered in text style, not emoji style

• Status: NEW
• Component: WebGPU

[Myles C. Maxfield]

Emoji with variation selectors are rendered in text style, not emoji style

[Myles C. Maxfield]

Created attachment 376534 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/53076002>

[Simon Fraser (smfr)]

Comment on attachment 376534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376534&action=review

> Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:65
> +        if (glyphs[i * glyphStep] && glyphs[i * glyphStep] != 0xFFFF) {

Can we make a constexpr for 0xFFFF please?

[EWS Watchlist]

Comment on attachment 376534 [details]
Patch

Attachment 376534 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12927172

New failing tests:
fast/text/emoji-variation-selector.html

[EWS Watchlist]

Created attachment 376546 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Myles C. Maxfield]

Created attachment 376583 [details]
Patch for commit

[WebKit Commit Bot]

Comment on attachment 376583 [details]
Patch for commit

Clearing flags on attachment: 376583

Committed r248815: <https://trac.webkit.org/changeset/248815>

[Darin Adler]

Comment on attachment 376583 [details]
Patch for commit

View in context: https://bugs.webkit.org/attachment.cgi?id=376583&action=review

> Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:50
> +static const constexpr CGGlyph deletedGlyph = 0xFFFF;

Something to explore for future coding style purposes:

I think that "constexpr" is sufficient here alone, and "static const" don’t add any useful additional semantics or behavior.