LocalStorageDatabase should use inline initialization for its data members.
Created attachment 376530 [details] Patch
Comment on attachment 376530 [details] Patch r=me
Comment on attachment 376530 [details] Patch Rejecting attachment 376530 [details] from review queue. wilander@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
(In reply to ews-feeder from comment #3) > Comment on attachment 376530 [details] > Patch > > Rejecting attachment 376530 [details] from review queue. > > wilander@apple.com does not have reviewer permissions according to > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > contributors.json. > > - If you do not have reviewer rights please read > http://webkit.org/coding/contributing.html for instructions on how to use > bugzilla flags. > > - If you have reviewer rights please correct the error in > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > the file (no review needed). The commit-queue restarts itself every 2 > hours. After restart the commit-queue will correctly respect your reviewer > rights. Darn it :P
(In reply to Chris Dumez from comment #4) > (In reply to ews-feeder from comment #3) > > Comment on attachment 376530 [details] > > Patch > > > > Rejecting attachment 376530 [details] from review queue. > > > > wilander@apple.com does not have reviewer permissions according to > > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > > contributors.json. > > > > - If you do not have reviewer rights please read > > http://webkit.org/coding/contributing.html for instructions on how to use > > bugzilla flags. > > > > - If you have reviewer rights please correct the error in > > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > > the file (no review needed). The commit-queue restarts itself every 2 > > hours. After restart the commit-queue will correctly respect your reviewer > > rights. > > Darn it :P Two hours. What year is this, 1995? :P
(In reply to John Wilander from comment #5) > (In reply to Chris Dumez from comment #4) > > (In reply to ews-feeder from comment #3) > > > Comment on attachment 376530 [details] > > > Patch > > > > > > Rejecting attachment 376530 [details] from review queue. > > > > > > wilander@apple.com does not have reviewer permissions according to > > > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > > > contributors.json. > > > > > > - If you do not have reviewer rights please read > > > http://webkit.org/coding/contributing.html for instructions on how to use > > > bugzilla flags. > > > > > > - If you have reviewer rights please correct the error in > > > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > > > the file (no review needed). The commit-queue restarts itself every 2 > > > hours. After restart the commit-queue will correctly respect your reviewer > > > rights. > > > > Darn it :P > > Two hours. What year is this, 1995? :P Yes, let's move to GitHub :D
Committed r248804: <https://trac.webkit.org/changeset/248804>
Comment on attachment 376530 [details] Patch Landed manually.
<rdar://problem/54413913>