Bug 200828 – LocalStorageDatabase should use inline initialization for its data members

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

LocalStorageDatabase should use inline initialization for its data members.

[Chris Dumez]

Created attachment 376530 [details]
Patch

[John Wilander]

Comment on attachment 376530 [details]
Patch

r=me

[EWS]

Comment on attachment 376530 [details]
Patch

Rejecting attachment 376530 [details] from review queue.

[e-mail] does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Chris Dumez]

(In reply to ews-feeder from comment #3)
> Comment on attachment 376530 [details]
> Patch
> 
> Rejecting attachment 376530 [details] from review queue.
> 
> [e-mail] does not have reviewer permissions according to
> https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/
> contributors.json.
> 
> - If you do not have reviewer rights please read
> http://webkit.org/coding/contributing.html for instructions on how to use
> bugzilla flags.
> 
> - If you have reviewer rights please correct the error in
> Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to
> the file (no review needed).  The commit-queue restarts itself every 2
> hours.  After restart the commit-queue will correctly respect your reviewer
> rights.

Darn it :P

[John Wilander]

(In reply to Chris Dumez from comment #4)
> (In reply to ews-feeder from comment #3)
> > Comment on attachment 376530 [details]
> > Patch
> > 
> > Rejecting attachment 376530 [details] from review queue.
> > 
> > [e-mail] does not have reviewer permissions according to
> > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/
> > contributors.json.
> > 
> > - If you do not have reviewer rights please read
> > http://webkit.org/coding/contributing.html for instructions on how to use
> > bugzilla flags.
> > 
> > - If you have reviewer rights please correct the error in
> > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to
> > the file (no review needed).  The commit-queue restarts itself every 2
> > hours.  After restart the commit-queue will correctly respect your reviewer
> > rights.
> 
> Darn it :P

Two hours. What year is this, 1995? :P

[Chris Dumez]

(In reply to John Wilander from comment #5)
> (In reply to Chris Dumez from comment #4)
> > (In reply to ews-feeder from comment #3)
> > > Comment on attachment 376530 [details]
> > > Patch
> > > 
> > > Rejecting attachment 376530 [details] from review queue.
> > > 
> > > [e-mail] does not have reviewer permissions according to
> > > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/
> > > contributors.json.
> > > 
> > > - If you do not have reviewer rights please read
> > > http://webkit.org/coding/contributing.html for instructions on how to use
> > > bugzilla flags.
> > > 
> > > - If you have reviewer rights please correct the error in
> > > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to
> > > the file (no review needed).  The commit-queue restarts itself every 2
> > > hours.  After restart the commit-queue will correctly respect your reviewer
> > > rights.
> > 
> > Darn it :P
> 
> Two hours. What year is this, 1995? :P

Yes, let's move to GitHub :D

[Chris Dumez]

Committed r248804: <https://trac.webkit.org/changeset/248804>

[Chris Dumez]

Comment on attachment 376530 [details]
Patch

Landed manually.

[Radar WebKit Bug Importer]

<rdar://problem/54413913>