Bug 200822 - LocalStorageDatabase does not need to subclass ThreadSafeRefCounted
Summary: LocalStorageDatabase does not need to subclass ThreadSafeRefCounted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-16 12:57 PDT by Chris Dumez
Modified: 2019-08-16 13:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2019-08-16 12:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.82 KB, patch)
2019-08-16 13:13 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-08-16 12:57:12 PDT 
LocalStorageDatabaseTracker does not need to subclass ThreadSafeRefCounted, it is only ref'd / deref'd by the StorageArea on the com.apple.WebKit.WebStorage serial WorkQueue, and in LocalStorageDatabase::scheduleDatabaseUpdate() on the same WorkQueue.
Comment 1 Chris Dumez 2019-08-16 12:58:16 PDT 
Created attachment 376519 [details]
Patch
Comment 2 Geoffrey Garen 2019-08-16 13:03:05 PDT 
Comment on attachment 376519 [details]
Patch

r=me
Comment 3 Chris Dumez 2019-08-16 13:13:23 PDT 
Created attachment 376526 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-16 13:56:06 PDT 
Comment on attachment 376526 [details]
Patch

Clearing flags on attachment: 376526

Committed r248794: <https://trac.webkit.org/changeset/248794>
Comment 5 WebKit Commit Bot 2019-08-16 13:56:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-16 13:57:18 PDT 
<rdar://problem/54406074>