Many WebStorage classes do not need to subclass ThreadSafeRefCounted. They never get ref'd or deref'd.
Created attachment 376518 [details] Patch
Comment on attachment 376518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376518&action=review r=me > Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp:54 > + return std::make_unique<StorageArea>(isEphemeral == IsEphemeral::Yes ? nullptr : this, WTFMove(securityOrigin), m_quotaInBytes); Should be makeUnique (here and elsewhere).
(In reply to Geoffrey Garen from comment #2) > Comment on attachment 376518 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376518&action=review > > r=me > > > Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp:54 > > + return std::make_unique<StorageArea>(isEphemeral == IsEphemeral::Yes ? nullptr : this, WTFMove(securityOrigin), m_quotaInBytes); > > Should be makeUnique (here and elsewhere). Again, that makeUnique patch las not landed yet :)
Comment on attachment 376518 [details] Patch Clearing flags on attachment: 376518 Committed r248792: <https://trac.webkit.org/changeset/248792>
All reviewed patches have been landed. Closing bug.
<rdar://problem/54405490>