Bug 200821 – Many WebStorage classes do not need to subclass ThreadSafeRefCounted

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Many WebStorage classes do not need to subclass ThreadSafeRefCounted. They never get ref'd or deref'd.

[Chris Dumez]

Created attachment 376518 [details]
Patch

[Geoffrey Garen]

Comment on attachment 376518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376518&action=review

r=me

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp:54
> +        return std::make_unique<StorageArea>(isEphemeral == IsEphemeral::Yes ? nullptr : this, WTFMove(securityOrigin), m_quotaInBytes);

Should be makeUnique (here and elsewhere).

[Chris Dumez]

(In reply to Geoffrey Garen from comment #2)
> Comment on attachment 376518 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376518&action=review
> 
> r=me
> 
> > Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp:54
> > +        return std::make_unique<StorageArea>(isEphemeral == IsEphemeral::Yes ? nullptr : this, WTFMove(securityOrigin), m_quotaInBytes);
> 
> Should be makeUnique (here and elsewhere).

Again, that makeUnique patch las not landed yet :)

[WebKit Commit Bot]

Comment on attachment 376518 [details]
Patch

Clearing flags on attachment: 376518

Committed r248792: <https://trac.webkit.org/changeset/248792>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54405490>