RESOLVED FIXED 200819
[ContentChangeObserver] Add ContentChangeObserver::elementDidBecomeHidden 
https://bugs.webkit.org/show_bug.cgi?id=200819
Summary [ContentChangeObserver] Add ContentChangeObserver::elementDidBecomeHidden
alan
Reported 2019-08-16 11:39:22 PDT
to track visible->hidden candidate elements.
Attachments
Patch (8.15 KB, patch)
2019-08-16 11:50 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.33 KB, patch)
2019-08-16 13:03 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-16 11:42:16 PDT
<rdar://problem/54400223>
alan
Comment 2 2019-08-16 11:50:40 PDT
Created attachment 376511 [details] Patch
Simon Fraser (smfr)
Comment 3 2019-08-16 12:00:50 PDT
Comment on attachment 376511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376511&action=review > Source/WebCore/page/ios/ContentChangeObserver.cpp:415 > + LOG(ContentObservation, "elementDidBecomeHidden: element went from visible to hidden"); Log the element addresss. > Source/WebCore/page/ios/ContentChangeObserver.cpp:652 > + auto wasHidden = m_wasHidden.value(); > + auto isVisible = isConsideredVisible(m_element); Can we just use "hidden" or "visible" in both code paths?
alan
Comment 4 2019-08-16 13:03:43 PDT
Created attachment 376521 [details] Patch
WebKit Commit Bot
Comment 5 2019-08-16 13:24:59 PDT
Comment on attachment 376521 [details] Patch Clearing flags on attachment: 376521 Committed r248790: <https://trac.webkit.org/changeset/248790>
WebKit Commit Bot
Comment 6 2019-08-16 13:25:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.