Bug 200819 - [ContentChangeObserver] Add ContentChangeObserver::elementDidBecomeHidden
Summary: [ContentChangeObserver] Add ContentChangeObserver::elementDidBecomeHidden
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-16 11:39 PDT by zalan
Modified: 2019-08-16 13:25 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.15 KB, patch)
2019-08-16 11:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.33 KB, patch)
2019-08-16 13:03 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-08-16 11:39:22 PDT 
to track visible->hidden candidate elements.
Comment 1 Radar WebKit Bug Importer 2019-08-16 11:42:16 PDT 
<rdar://problem/54400223>
Comment 2 zalan 2019-08-16 11:50:40 PDT 
Created attachment 376511 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-08-16 12:00:50 PDT 
Comment on attachment 376511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376511&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:415
> +    LOG(ContentObservation, "elementDidBecomeHidden: element went from visible to hidden");

Log the element addresss.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:652
> +    auto wasHidden = m_wasHidden.value();
> +    auto isVisible = isConsideredVisible(m_element);

Can we just use "hidden" or "visible" in both code paths?
Comment 4 zalan 2019-08-16 13:03:43 PDT 
Created attachment 376521 [details]
Patch
Comment 5 WebKit Commit Bot 2019-08-16 13:24:59 PDT 
Comment on attachment 376521 [details]
Patch

Clearing flags on attachment: 376521

Committed r248790: <https://trac.webkit.org/changeset/248790>
Comment 6 WebKit Commit Bot 2019-08-16 13:25:00 PDT 
All reviewed patches have been landed.  Closing bug.