Bug 200818 - StorageManager does not need to subclass RefCounted
Summary: StorageManager does not need to subclass RefCounted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-16 10:07 PDT by Chris Dumez
Modified: 2019-08-16 11:23 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.62 KB, patch)
2019-08-16 10:09 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-08-16 10:07:28 PDT
StorageManager does not need to subclass RefCounted. It is owned by the StorageManagerSet and is never ref'd / deref'd.
Comment 1 Chris Dumez 2019-08-16 10:09:15 PDT
Created attachment 376507 [details]
Patch
Comment 2 Geoffrey Garen 2019-08-16 10:27:28 PDT
Comment on attachment 376507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376507&action=review

r=me

> Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp:69
> +                return std::make_unique<StorageManager>(WTFMove(localStorageDirectory));

Please consider using WTF::makeUnique (a new helper added yesterday).
Comment 3 Chris Dumez 2019-08-16 10:29:33 PDT
(In reply to Geoffrey Garen from comment #2)
> Comment on attachment 376507 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376507&action=review
> 
> r=me
> 
> > Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp:69
> > +                return std::make_unique<StorageManager>(WTFMove(localStorageDirectory));
> 
> Please consider using WTF::makeUnique (a new helper added yesterday).

I would if it existed. The patch you're talking about does not seem to have landed.
Comment 4 WebKit Commit Bot 2019-08-16 11:22:22 PDT
Comment on attachment 376507 [details]
Patch

Clearing flags on attachment: 376507

Committed r248780: <https://trac.webkit.org/changeset/248780>
Comment 5 WebKit Commit Bot 2019-08-16 11:22:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-16 11:23:20 PDT
<rdar://problem/54399242>