Bug 200815 - [GTK][WPE] Enable service workers by default
Summary: [GTK][WPE] Enable service workers by default
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
Depends on: 203036
Blocks: 174541
  Show dependency treegraph
Reported: 2019-08-16 08:18 PDT by Carlos Alberto Lopez Perez
Modified: 2019-10-22 01:51 PDT (History)
15 users (show)

See Also:

Patch (3.89 KB, patch)
2019-10-21 14:25 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2019-08-16 08:18:43 PDT
Currently service workers is enabled only when building with -DENABLE_EXPERIMENTAL_FEATURES=ON

This feature has been in development since 2 years ago and Safari TP is already shipping it.

Anyone knows about any blocker before enabling this by default?

I will check the test pass-rates on WPT related tests.
Comment 1 Carlos Alberto Lopez Perez 2019-08-21 15:20:00 PDT
Running the JS and Ref tests for /service-workers on https://w3c-test.org/tools/runner/index.html gives the following result for the GTK MiniBrowser:

Passed: 1192
Failed:  198
Timeouts: 63
Errors:    2
Not run:  70

So, around 82% of pass-rate.
Comment 2 Carlos Alberto Lopez Perez 2019-10-21 14:21:25 PDT
Here is another manual test for SW: https://serviceworke.rs/message-relay_demo.html
it works fine
Comment 3 Carlos Alberto Lopez Perez 2019-10-21 14:25:01 PDT
Created attachment 381450 [details]
Comment 4 WebKit Commit Bot 2019-10-22 01:51:46 PDT
Comment on attachment 381450 [details]

Clearing flags on attachment: 381450

Committed r251424: <https://trac.webkit.org/changeset/251424>
Comment 5 WebKit Commit Bot 2019-10-22 01:51:48 PDT
All reviewed patches have been landed.  Closing bug.