Bug 200799 – [FTW] Enable CoreFoundation use if building for Apple target

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

This patch adds the last bits to get a semi-working MiniBrowser running with FTW.

[Brent Fulgham]

Actually, that was done previously -- this just makes it possible to use CF, which is needed for preferences.

[Brent Fulgham]

Created attachment 376449 [details]
Patch

[Alex Christensen]

Comment on attachment 376449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376449&action=review

> Source/cmake/OptionsFTW.cmake:218
> +    find_package(LibXml2 2.9.1 REQUIRED)

Isn't this just a minimum version?   I think it would be fine if the minimum version were the same for apple and non-apple.

> Source/cmake/OptionsFTW.cmake:-224
> -    find_package(LibXslt 1.1.32 REQUIRED)

ditto

[Brent Fulgham]

Comment on attachment 376449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376449&action=review

>> Source/cmake/OptionsFTW.cmake:218
>> +    find_package(LibXml2 2.9.1 REQUIRED)
> 
> Isn't this just a minimum version?   I think it would be fine if the minimum version were the same for apple and non-apple.

The non-Apple number is what Sony is using.I wanted to keep the two distinct where our distributions are different,

[WebKit Commit Bot]

Comment on attachment 376449 [details]
Patch

Clearing flags on attachment: 376449

Committed r248755: <https://trac.webkit.org/changeset/248755>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54373548>