Bug 200799 - [FTW] Enable CoreFoundation use if building for Apple target
Summary: [FTW] Enable CoreFoundation use if building for Apple target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-15 17:04 PDT by Brent Fulgham
Modified: 2019-08-15 18:51 PDT (History)
6 users (show)

See Also:


Attachments
Patch (12.18 KB, patch)
2019-08-15 17:30 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-08-15 17:04:50 PDT
This patch adds the last bits to get a semi-working MiniBrowser running with FTW.
Comment 1 Brent Fulgham 2019-08-15 17:13:35 PDT
Actually, that was done previously -- this just makes it possible to use CF, which is needed for preferences.
Comment 2 Brent Fulgham 2019-08-15 17:30:28 PDT
Created attachment 376449 [details]
Patch
Comment 3 Alex Christensen 2019-08-15 17:45:48 PDT
Comment on attachment 376449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376449&action=review

> Source/cmake/OptionsFTW.cmake:218
> +    find_package(LibXml2 2.9.1 REQUIRED)

Isn't this just a minimum version?   I think it would be fine if the minimum version were the same for apple and non-apple.

> Source/cmake/OptionsFTW.cmake:-224
> -    find_package(LibXslt 1.1.32 REQUIRED)

ditto
Comment 4 Brent Fulgham 2019-08-15 18:20:35 PDT
Comment on attachment 376449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376449&action=review

>> Source/cmake/OptionsFTW.cmake:218
>> +    find_package(LibXml2 2.9.1 REQUIRED)
> 
> Isn't this just a minimum version?   I think it would be fine if the minimum version were the same for apple and non-apple.

The non-Apple number is what Sony is using.I wanted to keep the two distinct where our distributions are different,
Comment 5 WebKit Commit Bot 2019-08-15 18:50:11 PDT
Comment on attachment 376449 [details]
Patch

Clearing flags on attachment: 376449

Committed r248755: <https://trac.webkit.org/changeset/248755>
Comment 6 WebKit Commit Bot 2019-08-15 18:50:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-15 18:51:21 PDT
<rdar://problem/54373548>