Bug 200791 - [iOS WK2] Scroll indicators disappear sometimes
Summary: [iOS WK2] Scroll indicators disappear sometimes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-15 15:17 PDT by Simon Fraser (smfr)
Modified: 2020-04-05 10:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (21.82 KB, patch)
2019-08-15 15:19 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Patch (21.95 KB, patch)
2019-08-16 20:49 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-08-15 15:17:12 PDT 
[iOS WK2] Scroll indicators disappear sometimes
Comment 1 Simon Fraser (smfr) 2019-08-15 15:19:36 PDT 
Created attachment 376430 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-08-15 15:20:18 PDT 
<rdar://problem/54364984>
Comment 3 EWS Watchlist 2019-08-15 15:21:49 PDT 
Attachment 376430 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2019-08-16 14:20:37 PDT 
Comment on attachment 376430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376430&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:41
> +@protocol WKWebKitControlled <NSObject>

Not sure about the name, but the concept seems sound. Clearly you should call it <WKView> 😉
Comment 5 Simon Fraser (smfr) 2019-08-16 20:49:15 PDT 
Created attachment 376588 [details]
Patch
Comment 6 EWS Watchlist 2019-08-16 20:51:49 PDT 
Attachment 376588 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm:37:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2019-08-17 08:27:45 PDT 
Comment on attachment 376588 [details]
Patch

Clearing flags on attachment: 376588

Committed r248820: <https://trac.webkit.org/changeset/248820>