Bug 200781 - Make getDisplayMedia follow user gesture for media
Summary: Make getDisplayMedia follow user gesture for media
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-15 12:39 PDT by youenn fablet
Modified: 2019-08-26 01:59 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.15 KB, patch)
2019-08-15 12:41 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-08-15 12:39:59 PDT 
Make getDisplayMedia follow user gesture for media
Comment 1 youenn fablet 2019-08-15 12:41:10 PDT 
Created attachment 376409 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-08-15 12:41:38 PDT 
<rdar://problem/54358510>
Comment 3 Eric Carlson 2019-08-19 05:59:51 PDT 
Comment on attachment 376409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376409&action=review

> Source/WebCore/Modules/mediastream/MediaDevices.cpp:129
> +    if (!m_disableGetDisplayMediaUserGestureConstraint && !document->processingUserGestureForMedia()) {

I'm not sure we want this because on mobile, UserGestureIndicator::processingUserGestureForMedia allows a touch start whereas UserGestureIndicator::processingUserGesture allows only a touch end.
Comment 4 youenn fablet 2019-08-26 01:59:19 PDT 
Let's keep the current behaviour which is more predictable for now.
We can revisit if we find some blocking scenarios.