RESOLVED FIXED 200780
[ContentChangeObserver] Rename contentVisibilityDidChange to elementDidBecomeVisible 
https://bugs.webkit.org/show_bug.cgi?id=200780
Summary [ContentChangeObserver] Rename contentVisibilityDidChange to elementDidBecome...
alan baradlay
Reported 2019-08-15 12:37:28 PDT
the new name is more accurate and we might need to track from visible to hidden changes as well.
Attachments
Patch (4.48 KB, patch)
2019-08-15 12:39 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (4.35 KB, patch)
2019-08-15 13:09 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (4.35 KB, patch)
2019-08-15 19:46 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-15 12:37:46 PDT
<rdar://problem/54358330>
alan baradlay
Comment 2 2019-08-15 12:39:55 PDT
Created attachment 376408 [details] Patch
Simon Fraser (smfr)
Comment 3 2019-08-15 13:04:14 PDT
Comment on attachment 376408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376408&action=review > Source/WebCore/page/ios/ContentChangeObserver.cpp:412 > +void ContentChangeObserver::visibilityChangedFromHiddenToVisible(const Element& element) elementDidBecomeVisible?
alan baradlay
Comment 4 2019-08-15 13:09:04 PDT
Created attachment 376414 [details] Patch
alan baradlay
Comment 5 2019-08-15 19:46:48 PDT
Created attachment 376467 [details] Patch
WebKit Commit Bot
Comment 6 2019-08-15 21:28:55 PDT
Comment on attachment 376467 [details] Patch Clearing flags on attachment: 376467 Committed r248761: <https://trac.webkit.org/changeset/248761>
WebKit Commit Bot
Comment 7 2019-08-15 21:28:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.