Bug 20078 - [GTK] Use G_* macros instead of deprecated GTK_* macros in gtk2xtbin.h
Summary: [GTK] Use G_* macros instead of deprecated GTK_* macros in gtk2xtbin.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-17 06:58 PDT by Wouter Bolsterlee
Modified: 2008-07-25 16:18 PDT (History)
1 user (show)

See Also:


Attachments
Proposed fix (1.18 KB, patch)
2008-07-17 07:03 PDT, Wouter Bolsterlee
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wouter Bolsterlee 2008-07-17 06:58:52 PDT
The GTK type checking macros have been deprecated in favor for the (identical) glib ones. Using the old ones breaks the build with -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED enabled.

Will attach a patch in a minute.
Comment 1 Wouter Bolsterlee 2008-07-17 07:03:57 PDT
Created attachment 22338 [details]
Proposed fix
Comment 2 Holger Freyther 2008-07-17 09:58:42 PDT
Comment on attachment 22338 [details]
Proposed fix

Compared with http://library.gnome.org/devel/gtk/stable/gtk-Types.html#GTK-CHECK-CAST:CAPS. I couldn't see a deprecation note though.
Comment 3 Wouter Bolsterlee 2008-07-17 12:18:56 PDT
It will be deprecated in the upcoming GTK release [1]. The corresponding Glib are also in the current stable release [2].

[1] http://library.gnome.org/devel/gtk/unstable/gtk-Types.html#GTK-CHECK-CAST:CAPS
    (note that there's "unstable", not "stable" in the url!)
[2] http://library.gnome.org/devel/gobject/stable/gobject-Type-Information.html#G-TYPE-CHECK-CLASS-CAST:CAPS
Comment 4 Wouter Bolsterlee 2008-07-17 12:22:04 PDT
Note that the GTK checks macros are exactly the same as the Glib macros, as can be seen in gtk+/gtk/gtktypeutils.h:

> /* glib macro wrappers (compatibility) */
> #define GTK_CHECK_CAST      G_TYPE_CHECK_INSTANCE_CAST
> #define GTK_CHECK_CLASS_CAST    G_TYPE_CHECK_CLASS_CAST
> #define GTK_CHECK_GET_CLASS G_TYPE_INSTANCE_GET_CLASS
> #define GTK_CHECK_TYPE      G_TYPE_CHECK_INSTANCE_TYPE
> #define GTK_CHECK_CLASS_TYPE    G_TYPE_CHECK_CLASS_TYPE
Comment 5 Jan Alonzo 2008-07-25 16:18:29 PDT
landed in r35361.