Bug 200778 - Yellow Lookup highlight gets stuck over Mail messages
Summary: Yellow Lookup highlight gets stuck over Mail messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-15 12:11 PDT by Tim Horton
Modified: 2019-08-15 13:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2019-08-15 12:11 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2019-08-15 12:14 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2019-08-15 12:16 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-08-15 12:11:01 PDT
Yellow Lookup highlight gets stuck over Mail messages
Comment 1 Tim Horton 2019-08-15 12:11:19 PDT
Created attachment 376404 [details]
Patch
Comment 2 Tim Horton 2019-08-15 12:11:22 PDT
<rdar://problem/53868514>
Comment 3 Tim Horton 2019-08-15 12:14:44 PDT
Created attachment 376405 [details]
Patch
Comment 4 Tim Horton 2019-08-15 12:16:41 PDT
Created attachment 376406 [details]
Patch
Comment 5 Wenson Hsieh 2019-08-15 12:19:04 PDT Comment hidden (obsolete)
Comment 6 Wenson Hsieh 2019-08-15 12:22:25 PDT
(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 376406 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376406&action=review
> 
> > Source/WebKitLegacy/mac/WebView/WebView.mm:9511
> > +        [weakSelf.get() _clearTextIndicatorWithAnimation:TextIndicatorWindowDismissalAnimation::FadeOut];
> 
> Nit - I don’t think the .get() is necessary here.

Oops, never mind — I take that back :/
Comment 7 WebKit Commit Bot 2019-08-15 13:21:12 PDT
Comment on attachment 376406 [details]
Patch

Clearing flags on attachment: 376406

Committed r248741: <https://trac.webkit.org/changeset/248741>
Comment 8 WebKit Commit Bot 2019-08-15 13:21:13 PDT
All reviewed patches have been landed.  Closing bug.