Bug 200777 – [ContentChangeObserver] Keep track of all the visibility candidates.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

instead of just the first one.

[Radar WebKit Bug Importer]

<rdar://problem/54356331>

[alan]

Created attachment 376402 [details]
Patch

[alan]

Created attachment 376457 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 376457 [details]
Patch

Rejecting attachment 376457 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 376457, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=376457&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=200777&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 376457 from bug 200777.
Fetching: https://bugs.webkit.org/attachment.cgi?id=376457
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	LayoutTests/fast/events/touch/ios/content-observation/going-from-hidden-to-visible-and-to-hidden2-expected.txt
	A	LayoutTests/fast/events/touch/ios/content-observation/going-from-hidden-to-visible-and-to-hidden2.html
	M	LayoutTests/ChangeLog
	M	Source/WTF/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WTF/ChangeLog' is out of date
W: c2938c11c53c9fe0fdff44709902fc7d8a02be23 and refs/remotes/origin/master differ, using rebase:
:040000 040000 f52a1bc293ff1d2ccef0aecec188b2813da16c94 62a6e46a1b238bf5dbb47993838afa5da281b98d M	LayoutTests
:040000 040000 3b878fcc6fb75321c2b0450dc0b85146a53a3f03 13b9b028a714f593ebf63ae48402e72fc9c93570 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	LayoutTests/fast/events/touch/ios/content-observation/going-from-hidden-to-visible-and-to-hidden2-expected.txt
	A	LayoutTests/fast/events/touch/ios/content-observation/going-from-hidden-to-visible-and-to-hidden2.html
	M	LayoutTests/ChangeLog
	M	Source/WTF/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WTF/ChangeLog' is out of date
W: c2938c11c53c9fe0fdff44709902fc7d8a02be23 and refs/remotes/origin/master differ, using rebase:
:040000 040000 f52a1bc293ff1d2ccef0aecec188b2813da16c94 62a6e46a1b238bf5dbb47993838afa5da281b98d M	LayoutTests
:040000 040000 3b878fcc6fb75321c2b0450dc0b85146a53a3f03 13b9b028a714f593ebf63ae48402e72fc9c93570 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   edb552b54fe..ab26b4a493d  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 248753 = edb552b54fee996459e24bdff27a8247c62fb9cf
r248754 = ab26b4a493d44aa8143378eb57f5a849a1c3ec01
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/12921529

[alan]

Created attachment 376463 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 376463 [details]
Patch

Clearing flags on attachment: 376463

Committed r248759: <https://trac.webkit.org/changeset/248759>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 376463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376463&action=review

> Source/WebCore/page/ios/ContentChangeObserver.h:210
> +    WeakHashSet<Element> m_visibilityCandidateList;

Seems a little risky to have an unordered set and call it "list", which typically means ordered.

[alan]

(In reply to Darin Adler from comment #8)
> Comment on attachment 376463 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376463&action=review
> 
> > Source/WebCore/page/ios/ContentChangeObserver.h:210
> > +    WeakHashSet<Element> m_visibilityCandidateList;
> 
> Seems a little risky to have an unordered set and call it "list", which
> typically means ordered.
Oops. Indeed.

[alan]

Created attachment 376663 [details]
Post-patch

[alan]

Created attachment 376664 [details]
Post-land