Bug 200773 - [ContentChangeObserver] Dispatch synthetic click when the visibility candidate element becomes hidden again.
Summary: [ContentChangeObserver] Dispatch synthetic click when the visibility candidat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-15 10:25 PDT by zalan
Modified: 2019-08-15 15:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (18.18 KB, patch)
2019-08-15 10:38 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (18.17 KB, patch)
2019-08-15 11:17 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (18.17 KB, patch)
2019-08-15 11:47 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-08-15 10:25:57 PDT
going from hidden to visible and back to hidden again.
Comment 1 Radar WebKit Bug Importer 2019-08-15 10:26:14 PDT
<rdar://problem/54351728>
Comment 2 zalan 2019-08-15 10:38:34 PDT
Created attachment 376392 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-08-15 11:11:21 PDT
Comment on attachment 376392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376392&action=review

> Source/WebCore/ChangeLog:9
> +        This patch fixes the case when the candidate element (going from hidden to visible) becomes hidden by the end of the obvservation window. It essentially means that no visible change has happened

obvservation
Comment 4 zalan 2019-08-15 11:17:16 PDT
Created attachment 376397 [details]
Patch
Comment 5 WebKit Commit Bot 2019-08-15 11:42:44 PDT
Comment on attachment 376397 [details]
Patch

Rejecting attachment 376397 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 376397, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/12919033
Comment 6 zalan 2019-08-15 11:47:54 PDT
Created attachment 376401 [details]
Patch
Comment 7 WebKit Commit Bot 2019-08-15 15:19:03 PDT
Comment on attachment 376401 [details]
Patch

Clearing flags on attachment: 376401

Committed r248750: <https://trac.webkit.org/changeset/248750>
Comment 8 WebKit Commit Bot 2019-08-15 15:19:04 PDT
All reviewed patches have been landed.  Closing bug.