RESOLVED FIXED 200773
[ContentChangeObserver] Dispatch synthetic click when the visibility candidate element becomes hidden again.
https://bugs.webkit.org/show_bug.cgi?id=200773
Summary [ContentChangeObserver] Dispatch synthetic click when the visibility candidat...
alan
Reported 2019-08-15 10:25:57 PDT
going from hidden to visible and back to hidden again.
Attachments
Patch (18.18 KB, patch)
2019-08-15 10:38 PDT, alan
no flags
Patch (18.17 KB, patch)
2019-08-15 11:17 PDT, alan
no flags
Patch (18.17 KB, patch)
2019-08-15 11:47 PDT, alan
no flags
Radar WebKit Bug Importer
Comment 1 2019-08-15 10:26:14 PDT
alan
Comment 2 2019-08-15 10:38:34 PDT
Simon Fraser (smfr)
Comment 3 2019-08-15 11:11:21 PDT
Comment on attachment 376392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376392&action=review > Source/WebCore/ChangeLog:9 > + This patch fixes the case when the candidate element (going from hidden to visible) becomes hidden by the end of the obvservation window. It essentially means that no visible change has happened obvservation
alan
Comment 4 2019-08-15 11:17:16 PDT
WebKit Commit Bot
Comment 5 2019-08-15 11:42:44 PDT
Comment on attachment 376397 [details] Patch Rejecting attachment 376397 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 376397, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12919033
alan
Comment 6 2019-08-15 11:47:54 PDT
WebKit Commit Bot
Comment 7 2019-08-15 15:19:03 PDT
Comment on attachment 376401 [details] Patch Clearing flags on attachment: 376401 Committed r248750: <https://trac.webkit.org/changeset/248750>
WebKit Commit Bot
Comment 8 2019-08-15 15:19:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.