Bug 200768 - Add shared-mime-info to WPE WebKit jhbuild
Summary: Add shared-mime-info to WPE WebKit jhbuild
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-15 06:44 PDT by Chris Lord
Modified: 2019-08-16 02:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2019-08-16 01:13 PDT, Chris Lord 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2019-08-15 06:44:26 PDT 
Much like the Gtk backend, the WPE backend also relies on shared-mime-info to determine filetypes on a local filesystem. As it's not currently in the jhbuild modules, it will rely on the system one. This became evident recently as shared-mime-info 1.12 (current release as of writing, and included in Fedora 30) causes some html files to be incorrectly identified as xhtml, which in turn causes test failures (and weird behaviour for local files). To circumvent this, we should build shared-mime-info in jhbuild and rely on that version.
Comment 1 Chris Lord 2019-08-16 01:13:52 PDT 
Created attachment 376483 [details]
Patch
Comment 2 WebKit Commit Bot 2019-08-16 02:22:24 PDT 
Comment on attachment 376483 [details]
Patch

Clearing flags on attachment: 376483

Committed r248767: <https://trac.webkit.org/changeset/248767>
Comment 3 WebKit Commit Bot 2019-08-16 02:22:26 PDT 
All reviewed patches have been landed.  Closing bug.