Bug 200759 - [JSC] Air does not appropriately propagate ConstFloatValue to stackmap
Summary: [JSC] Air does not appropriately propagate ConstFloatValue to stackmap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 200362
  Show dependency tree / graph
 
Reported: 2019-08-14 22:52 PDT by Yusuke Suzuki
Modified: 2019-08-14 23:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.60 KB, patch)
2019-08-14 23:01 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (9.62 KB, patch)
2019-08-14 23:29 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-08-14 22:52:30 PDT 
[JSC] Air does not appropriately propagate ConstFloatValue to stackmap
Comment 1 Yusuke Suzuki 2019-08-14 23:01:36 PDT 
Created attachment 376357 [details]
Patch
Comment 2 EWS Watchlist 2019-08-14 23:06:38 PDT 
Attachment 376357 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:48:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:80:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2019-08-14 23:29:14 PDT 
Created attachment 376361 [details]
Patch
Comment 4 EWS Watchlist 2019-08-14 23:35:42 PDT 
Attachment 376361 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:48:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:80:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Yusuke Suzuki 2019-08-14 23:37:17 PDT 
Thanks for review!
Comment 6 Yusuke Suzuki 2019-08-14 23:39:33 PDT 
Committed r248710: <https://trac.webkit.org/changeset/248710>
Comment 7 Radar WebKit Bug Importer 2019-08-14 23:40:15 PDT 
<rdar://problem/54335168>