RESOLVED FIXED 200756
Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...) 
https://bugs.webkit.org/show_bug.cgi?id=200756
Summary Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
Sam Weinig
Reported 2019-08-14 20:46:50 PDT
Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
Attachments
Patch (74.44 KB, patch)
2019-08-14 20:52 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (75.94 KB, patch)
2019-08-16 20:07 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (79.99 KB, patch)
2019-08-16 20:17 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (80.68 KB, patch)
2019-08-17 07:44 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (83.01 KB, patch)
2019-08-17 08:04 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2019-08-14 20:52:32 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 2 2019-08-14 23:04:11 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2019-08-16 20:07:42 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2019-08-16 20:17:36 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2019-08-17 07:44:34 PDT Comment hidden (obsolete)
Sam Weinig
Comment 6 2019-08-17 08:04:27 PDT
Created attachment 376609 [details] Patch
Darin Adler
Comment 7 2019-08-17 11:19:14 PDT
Comment on attachment 376609 [details] Patch A next cleanup step would be to remove other overloads of StringBuilder::append that are redundant because append(...) does the same thing (even with one argument).
Darin Adler
Comment 8 2019-08-17 11:46:23 PDT
And then another is to change most appendNumber callers to just call append, since it does there right thing. And remove most appendNumber overloads. Then consider removing appendFixedPrecisionNumber and appendFixedWidthNumber and use FormattedNumber instead.
WebKit Commit Bot
Comment 9 2019-08-17 11:49:44 PDT
Comment on attachment 376609 [details] Patch Clearing flags on attachment: 376609 Committed r248822: <https://trac.webkit.org/changeset/248822>
WebKit Commit Bot
Comment 10 2019-08-17 11:49:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-08-17 11:50:21 PDT
<rdar://problem/54430185>
Note You need to log in before you can comment on or make changes to this bug.