Bug 200749 – [WHLSL] Make operator== native and add bool matrices

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Saam Barati]

...

[Saam Barati]

Created attachment 376458 [details]
patch

[Myles C. Maxfield]

Comment on attachment 376458 [details]
patch

We should make sure we modify the spec to include the new functionality.

[Saam Barati]

Comment on attachment 376458 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376458&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:16299
> +native bool2 operator==(bool2 a, bool2 b) ;

oops, I'll fix styling on these.

[Saam Barati]

Created attachment 376459 [details]
patch

[Myles C. Maxfield]

Comment on attachment 376458 [details]
patch

This seems like not enough tests for adding a whole new type. By my count, this patch adds 32 functions and modifies 30 functions, but only tests 3 of them?

[Myles C. Maxfield]

Comment on attachment 376459 [details]
patch

Inequalities need to be matrices too

[Myles C. Maxfield]

checkOperatorOverload and writeNativeType and Intrinsics::addMatrix need to be modified

[Myles C. Maxfield]

https://github.com/gpuweb/WHLSL/commit/f51fc5f77ca4437dc0e3845b89c8e6158292616d

[Saam Barati]

(In reply to Myles C. Maxfield from comment #6)
> Comment on attachment 376459 [details]
> patch
> 
> Inequalities need to be matrices too

doing this in:
https://bugs.webkit.org/show_bug.cgi?id=200823

[Saam Barati]

Created attachment 376520 [details]
patch

[Saam Barati]

Created attachment 376528 [details]
patch

[Myles C. Maxfield]

https://github.com/gpuweb/WHLSL/commit/6f58ad3e265a11822d42f4110769ecb76eef445e

[WebKit Commit Bot]

Comment on attachment 376528 [details]
patch

Clearing flags on attachment: 376528

Committed r248795: <https://trac.webkit.org/changeset/248795>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54406208>

[Truitt Savell]

The new test webgpu/whlsl/bool-matrix.html

added in https://trac.webkit.org/changeset/248795/webkit

is failing on Mojave.

History:
http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgpu%2Fwhlsl%2Fbool-matrix.html

Diff:
--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/webgpu/whlsl/bool-matrix-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/webgpu/whlsl/bool-matrix-actual.txt
@@ -1,11 +1,11 @@
 
 PASS boolMatrix 
-PASS boolMatrix2 
-PASS boolMatrix3 
-PASS boolMatrix4 
+FAIL boolMatrix2 promise_test: Unhandled rejection with value: object "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot resolve function call to a concrete callee. Make sure you are using compatible types."
+FAIL boolMatrix3 promise_test: Unhandled rejection with value: object "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot resolve function call to a concrete callee. Make sure you are using compatible types."
+FAIL boolMatrix4 promise_test: Unhandled rejection with value: object "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot resolve function call to a concrete callee. Make sure you are using compatible types."
 PASS boolMatrix5 
-PASS boolMatrixAny 
-PASS boolMatrixAny2 
-PASS boolMatrixAll 
-PASS boolMatrixAll2 
+FAIL boolMatrixAny promise_test: Unhandled rejection with value: object "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot resolve function call to a concrete callee. Make sure you are using compatible types."
+FAIL boolMatrixAny2 promise_test: Unhandled rejection with value: object "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot resolve function call to a concrete callee. Make sure you are using compatible types."
+FAIL boolMatrixAll promise_test: Unhandled rejection with value: object "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot resolve function call to a concrete callee. Make sure you are using compatible types."
+FAIL boolMatrixAll2 promise_test: Unhandled rejection with value: object "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot resolve function call to a concrete callee. Make sure you are using compatible types."

[Saam Barati]

(In reply to Truitt Savell from comment #16)
> The new test webgpu/whlsl/bool-matrix.html
> 
> added in https://trac.webkit.org/changeset/248795/webkit
> 
> is failing on Mojave.
> 
> History:
> http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=webgpu%2Fwhlsl%2Fbool-matrix.html
> 
> Diff:
> ---
> /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> webgpu/whlsl/bool-matrix-expected.txt
> +++
> /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> webgpu/whlsl/bool-matrix-actual.txt
> @@ -1,11 +1,11 @@
>  
>  PASS boolMatrix 
> -PASS boolMatrix2 
> -PASS boolMatrix3 
> -PASS boolMatrix4 
> +FAIL boolMatrix2 promise_test: Unhandled rejection with value: object
> "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot
> resolve function call to a concrete callee. Make sure you are using
> compatible types."
> +FAIL boolMatrix3 promise_test: Unhandled rejection with value: object
> "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot
> resolve function call to a concrete callee. Make sure you are using
> compatible types."
> +FAIL boolMatrix4 promise_test: Unhandled rejection with value: object
> "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot
> resolve function call to a concrete callee. Make sure you are using
> compatible types."
>  PASS boolMatrix5 
> -PASS boolMatrixAny 
> -PASS boolMatrixAny2 
> -PASS boolMatrixAll 
> -PASS boolMatrixAll2 
> +FAIL boolMatrixAny promise_test: Unhandled rejection with value: object
> "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot
> resolve function call to a concrete callee. Make sure you are using
> compatible types."
> +FAIL boolMatrixAny2 promise_test: Unhandled rejection with value: object
> "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot
> resolve function call to a concrete callee. Make sure you are using
> compatible types."
> +FAIL boolMatrixAll promise_test: Unhandled rejection with value: object
> "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot
> resolve function call to a concrete callee. Make sure you are using
> compatible types."
> +FAIL boolMatrixAll2 promise_test: Unhandled rejection with value: object
> "Error: GPUDevice.createComputePipeline(): WHLSL compile error: 3:25: Cannot
> resolve function call to a concrete callee. Make sure you are using
> compatible types."

Looking into this now. It doesn't seem to be failing for me. So I'll update my checkout

[Saam Barati]

Looks like a bad merge when I rebased and things got moved around in the standard library :/

[Saam Barati]

(In reply to Saam Barati from comment #18)
> Looks like a bad merge when I rebased and things got moved around in the
> standard library :/

This breaks things because we have a particular organization in the standard library we depend on when parsing functions with particular names. Fix forthcoming

[Saam Barati]

fixed in:
https://trac.webkit.org/changeset/248801/webkit