Bug 200739 - ProxyObject should not be allow to access its target's private properties.
Summary: ProxyObject should not be allow to access its target's private properties.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on: 200829
Blocks:
  Show dependency treegraph
 
Reported: 2019-08-14 15:39 PDT by Mark Lam
Modified: 2019-08-16 14:04 PDT (History)
10 users (show)

See Also:


Attachments
proposed patch. (4.40 KB, patch)
2019-08-14 15:50 PDT, Mark Lam
ysuzuki: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
patch for landing. (4.99 KB, patch)
2019-08-14 20:26 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-08-14 15:39:38 PDT
<rdar://problem/53972768>
Comment 1 Mark Lam 2019-08-14 15:50:09 PDT
Created attachment 376324 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2019-08-14 15:54:03 PDT
Comment on attachment 376324 [details]
proposed patch.

r=me
Comment 3 EWS Watchlist 2019-08-14 18:56:53 PDT
Comment on attachment 376324 [details]
proposed patch.

Attachment 376324 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/12914309

New failing tests:
stress/proxy-with-private-symbols.js.ftl-no-cjit-no-inline-validate
stress/proxy-with-private-symbols.js.dfg-eager-no-cjit-validate
stress/proxy-with-private-symbols.js.ftl-no-cjit-no-put-stack-validate
stress/proxy-with-private-symbols.js.no-ftl
stress/proxy-with-private-symbols.js.ftl-no-cjit-validate-sampling-profiler
stress/proxy-with-private-symbols.js.no-cjit-validate-phases
stress/proxy-with-private-symbols.js.ftl-no-cjit-small-pool
stress/proxy-with-private-symbols.js.dfg-maximal-flush-validate-no-cjit
stress/proxy-with-private-symbols.js.default
stress/proxy-with-private-symbols.js.ftl-eager-no-cjit
stress/proxy-with-private-symbols.js.mini-mode
stress/proxy-with-private-symbols.js.bytecode-cache
stress/proxy-with-private-symbols.js.ftl-eager
stress/proxy-with-private-symbols.js.dfg-eager
stress/proxy-with-private-symbols.js.ftl-no-cjit-b3o0
stress/proxy-with-private-symbols.js.ftl-eager-no-cjit-b3o1
stress/proxy-with-private-symbols.js.no-cjit-collect-continuously
stress/proxy-with-private-symbols.js.no-llint
Comment 4 Mark Lam 2019-08-14 20:26:17 PDT
Created attachment 376346 [details]
patch for landing.
Comment 5 Mark Lam 2019-08-14 23:20:56 PDT
Thanks for the review.  Landed in r248709: <http://trac.webkit.org/r248709>.
Comment 6 Ryan Haddad 2019-08-16 13:09:21 PDT
Reverted r248709 for reason:

Caused test/built-ins/Promise/prototype/finally/this-value-non-promise.js to fail on test262 bot

Committed r248786: <https://trac.webkit.org/changeset/248786>
Comment 7 Ryan Haddad 2019-08-16 13:09:35 PDT
(In reply to Ryan Haddad from comment #6)
> Reverted r248709 for reason:
> 
> Caused test/built-ins/Promise/prototype/finally/this-value-non-promise.js to
> fail on test262 bot
> 
> Committed r248786: <https://trac.webkit.org/changeset/248786>

Details in https://bugs.webkit.org/show_bug.cgi?id=200788
Comment 8 Mark Lam 2019-08-16 14:04:23 PDT
Re-landed in r248796: <http://trac.webkit.org/r248796>.