Bug 200736 – Web Inspector: there should be an opposite icon for Eye.svg when we want to hide things instead of showing them

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

We currently use Eye.svg for disabling, or turning "off", Shader Programs, but it's not very clear that clicking on the eye (which looks like "show me this", not "hide this") will do that.  Furthermore, a greyed out version also isn't clear that the Shader Program is disabled, instead making the user think that the disable toggle is somehow "not working".  A better icon would fix these issues.

[Devin Rousso]

Created attachment 376311 [details]
Patch

[Devin Rousso]

Created attachment 376312 [details]
[Image] After Patch is applied

[Joseph Pecoraro]

Comment on attachment 376311 [details]
Patch

Shouldn't such a toggle be toggling between Eye / Hide?

• Enabled has "Hide" icon => click => Disable + Show "Eye" icon
• Disabled has "Eye" icon => click => Enable + Show "Hide" icon

I like not applying the opacity filter to the status button.

[Joseph Pecoraro]

> • Enabled has "Hide" icon => click => Disable + Show "Eye" icon
> • Disabled has "Eye" icon => click => Enable + Show "Hide" icon

Err, probably invert the icons I suggested. You probably want the Hide icon to show when the script is disabled, as that is the "status" of the shader. Clicking will change the status.

[Devin Rousso]

(In reply to Joseph Pecoraro from comment #4)
> > • Enabled has "Hide" icon => click => Disable + Show "Eye" icon
> > • Disabled has "Eye" icon => click => Enable + Show "Hide" icon
> 
> Err, probably invert the icons I suggested. You probably want the Hide icon to show when the script is disabled, as that is the "status" of the shader. Clicking will change the status.
My only issue with doing something like this is that if we use a simple `:hover` selector, then as soon as the user clicks to disable the shader, the "Eye" suddenly becomes a "Hide" as the `.disabled:hover` would now apply.  Ideally, we'd wait till the _next_ time the user hovers over the icon to switch from "Hide.svg" to "Eye.svg". 

Then again, breakpoints switch immediately after the click, so maybe I'm overthinking things :P

[Devin Rousso]

Created attachment 376509 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 376509 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 376509 [details]
Patch

Clearing flags on attachment: 376509

Committed r248782: <https://trac.webkit.org/changeset/248782>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54402848>