Bug 200721 - results.webkit.org: Add content hook to FlaskRequestsResponse
Summary: results.webkit.org: Add content hook to FlaskRequestsResponse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-14 09:40 PDT by Jonathan Bedard
Modified: 2019-08-15 10:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2019-08-14 09:44 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.29 KB, patch)
2019-08-14 11:18 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-08-14 09:40:28 PDT 
The flask 'Response' class stores the raw bytes associated with the response as 'data'. Requests stores it as 'content'. Add a hook to the FlaskRequestsResponse class so that it conforms to the same API as requests.
Comment 1 Jonathan Bedard 2019-08-14 09:44:03 PDT 
Created attachment 376274 [details]
Patch
Comment 2 Aakash Jain 2019-08-14 09:46:40 PDT 
Comment on attachment 376274 [details]
Patch

rs=me
Comment 3 Jonathan Bedard 2019-08-14 11:18:08 PDT 
Created attachment 376284 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-08-15 10:35:08 PDT 
Comment on attachment 376284 [details]
Patch for landing

Clearing flags on attachment: 376284

Committed r248727: <https://trac.webkit.org/changeset/248727>
Comment 5 WebKit Commit Bot 2019-08-15 10:35:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-15 10:36:16 PDT 
<rdar://problem/54352248>