Bug 200707 - [GTK][WPE] Move TextureMapperAnimation to the nicosia namespace as NicosiaAnimation
Summary: [GTK][WPE] Move TextureMapperAnimation to the nicosia namespace as NicosiaAni...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-14 02:29 PDT by Miguel Gomez
Modified: 2019-08-16 07:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (50.94 KB, patch)
2019-08-14 02:37 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff
Patch (51.39 KB, patch)
2019-08-14 06:25 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff
Patch (51.04 KB, patch)
2019-08-16 02:39 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff
Patch (51.04 KB, patch)
2019-08-16 06:03 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2019-08-14 02:29:39 PDT
TextureMapperAnimation's functionality is not really tied. I can be used (an will be used) by non TextureMapper implementations, so move it to a proper place.
Comment 1 Miguel Gomez 2019-08-14 02:37:14 PDT
Created attachment 376253 [details]
Patch
Comment 2 Miguel Gomez 2019-08-14 06:25:11 PDT
Created attachment 376261 [details]
Patch
Comment 3 Miguel Gomez 2019-08-16 02:39:02 PDT
Created attachment 376487 [details]
Patch
Comment 4 Zan Dobersek 2019-08-16 04:09:18 PDT
Comment on attachment 376487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376487&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:42
>  class PaintingEngine;
> +class Animations;

Nit: alphabetic ordering.
Comment 5 Miguel Gomez 2019-08-16 06:03:23 PDT
Created attachment 376495 [details]
Patch
Comment 6 WebKit Commit Bot 2019-08-16 07:37:26 PDT
Comment on attachment 376495 [details]
Patch

Clearing flags on attachment: 376495

Committed r248769: <https://trac.webkit.org/changeset/248769>
Comment 7 WebKit Commit Bot 2019-08-16 07:37:27 PDT
All reviewed patches have been landed.  Closing bug.